Uh oh!
There was an error while loading. Please reload this page.
test: remove unused util imports - #4397
Closed
Trott wants to merge 1 commit into
Closed
Conversation
A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements.
rvagg
commented
Dec 23, 2015
Member
cjihrig
commented
Dec 23, 2015
Contributor
LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Dec 25, 2015
A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements. PR-URL: nodejs#4397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Trott
commented
Dec 25, 2015
MemberAuthor
Landed in 3311267 |
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements. PR-URL: nodejs#4397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins
commented
Jan 7, 2016
Contributor
I seems like some of these "unused" utils are still be used in LTS. @Trott do you want to open a different PR to backport this? |
Trott
commented
Jan 7, 2016
MemberAuthor
@thealphanerdwant is a strong word, but I suppose I can do it. So, uh, how? Do I just open a PR against some branch that isn't |
Trott
commented
Jan 7, 2016
MemberAuthor
Ah, I see in another issue you specify v4.x-staging. Sure, I'll get to that. |
Trott
commented
Jan 7, 2016
MemberAuthor
@thealphanerd: Here you go: #4562 |
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements. PR-URL: nodejs#4397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of tests in
test/parallelwere importing theutilmodulevia
require()but not usingutilfor anything. This removes thoserequire()statements.