Uh oh!
There was an error while loading. Please reload this page.
doc: fix added version for readable.closed/destroyed properties - #44033
Closed
MasterOdin wants to merge 1 commit into
Closed
doc: fix added version for readable.closed/destroyed properties#44033MasterOdin wants to merge 1 commit into
MasterOdin wants to merge 1 commit into
Conversation
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
lpinca
approved these changes
Jul 29, 2022
nodejs-github-bot
commented
Aug 15, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44033
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
at consumeBody (file:///opt/hostedtoolcache/node/16.16.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Response.text (file:///opt/hostedtoolcache/node/16.16.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
at async Request.json (file:///opt/hostedtoolcache/node/16.16.0/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
at async Request.query (file:///opt/hostedtoolcache/node/16.16.0/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
at async Request.queryAll (file:///opt/hostedtoolcache/node/16.16.0/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
at async Request.gql (file:///opt/hostedtoolcache/node/16.16.0/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
at async PRData.getComments (file:///opt/hostedtoolcache/node/16.16.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
at async Promise.all (index 2)
at async Promise.all (index 1) {
type: 'system',
errno: 'ERR_STREAM_PREMATURE_CLOSE',
code: 'ERR_STREAM_PREMATURE_CLOSE',
erroredSysCall: undefined
}https://github.com/nodejs/node/actions/runs/2862588497 |
lpinca pushed a commit
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> PR-URL: #44033 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
lpinca
commented
Aug 15, 2022
Member
Landed in fc03249. |
danielleadams pushed a commit
that referenced
this pull request
Aug 16, 2022
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> PR-URL: #44033 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno pushed a commit
that referenced
this pull request
Aug 23, 2022
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> PR-URL: #44033 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol
commented
Sep 29, 2022
Member
As described, this is a v18.x-only change; I will proceed w/ adding the respective labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR reverses the added versions for
readable.closedandreadable.destroyed, as I believe thatclosedwas added in v18 anddestroyedwas added in v8 (from looking at the v17 and earlier docs for this page which doesn't mentionclosedand putsdestroyedas v8).