Skip to content

src,lib: print prinstine source when source map source not found - #44052

Closed
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:test-error-source
Closed

src,lib: print prinstine source when source map source not found#44052
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:test-error-source

Conversation

@legendecas

@legendecaslegendecas commented Jul 30, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent.

Refs: #44019

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 30, 2022
@legendecas
legendecas marked this pull request as ready for review July 30, 2022 08:36
@legendecas
legendecas requested a review from bcoeAugust 1, 2022 15:36
bcoe
bcoe approved these changes Aug 3, 2022
View reviewed changes
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45829/

legendecas
legendecas commented Aug 4, 2022
View reviewed changes
Comment threadlib/internal/source_map/prepare_stack_trace.js
Comment on lines +149 to +151
if (typeof source !== 'string') {
return;
}

This comment was marked as outdated.

Sign in to view

@legendecas

legendecas commented Aug 6, 2022

Copy link
Copy Markdown
MemberAuthor

Landed in 0a2c910

@legendecas
legendecas deleted the test-error-source branch August 6, 2022 11:57
legendecas added a commit that referenced this pull request Aug 6, 2022
@legendecas
src,lib: print prinstine source when source map source not found
0a2c910
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.
PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@legendecas@danielleadams
src,lib: print prinstine source when source map source not found
63b5c49
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.
PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@legendecas@ruyadorno
src,lib: print prinstine source when source map source not found
ee6412a
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.
PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@ruyadornoruyadorno mentioned this pull request Aug 23, 2022
Merged
@juanarbol

juanarbol commented Sep 26, 2022

Copy link
Copy Markdown
Member

This depends on #43875 to be landed in v16.x

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bcoebcoebcoe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas@nodejs-github-bot@juanarbol@bcoe