Skip to content

src: remove usages of GetBackingStore in modules - #44076

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kvakil:modules-backingstores
Aug 3, 2022
Merged

src: remove usages of GetBackingStore in modules#44076
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kvakil:modules-backingstores

Conversation

@kvakil

@kvakilkvakil commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

This removes all usages of GetBackingStore in modules. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921

@kvakil
src: remove usages of GetBackingStore in modules
b43ecac
This removes all usages of GetBackingStore in modules. See the linked
issue for an explanation.
Refs: nodejs#32226
Refs: nodejs#43921
@nodejs-github-bot

nodejs-github-bot commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
  • @nodejs/vm

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Aug 1, 2022
@kvakilkvakil mentioned this pull request Aug 1, 2022
Merged
@F3n67uF3n67u added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2022
mcollina
mcollina approved these changes Aug 1, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kvakilkvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2022
@F3n67uF3n67u removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45762/

@kvakilkvakil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2022
@kvakilkvakil self-assigned this Aug 1, 2022
@kvakilkvakil added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 4eaaa17 into nodejs:mainAug 3, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4eaaa17

danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@kvakil@danielleadams
src: remove usages of GetBackingStore in modules
34a92d1
This removes all usages of GetBackingStore in modules. See the linked
issue for an explanation.
Refs: #32226
Refs: #43921
PR-URL: #44076
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@kvakil@ruyadorno
src: remove usages of GetBackingStore in modules
cddf3ed
This removes all usages of GetBackingStore in modules. See the linked
issue for an explanation.
Refs: #32226
Refs: #43921
PR-URL: #44076
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@ruyadornoruyadorno mentioned this pull request Aug 23, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@santigimenosantigimenosantigimeno approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+2 more reviewers
@F3n67uF3n67uF3n67u approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kvakilkvakil

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kvakil@nodejs-github-bot@mcollina@addaleax@santigimeno@F3n67u@RaisinTen@VoltrexKeyva@targos