Uh oh!
There was an error while loading. Please reload this page.
[v16.x backport] events: add CustomEvent - #44082
Closed
aduh95 wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Aug 1, 2022
Collaborator
Review requested:
|
targos
commented
Aug 1, 2022
Member
Can you please rebase? I removed a7677bc from staging |
This implements the Web API `CustomEvent` in `internal/event_target`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs#43514 Refs: nodejs#40678 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs#43885Fixes: nodejs#40678 Refs: nodejs#43514 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
aduh95force-pushed
the
backport-CustomEvent
branch
from
August 1, 2022 21:36
112b2a1 to
63c33e2Comparedaeyeon
commented
Aug 2, 2022
Member
@aduh95 Thanks for this backporting. |
nodejs-github-bot
commented
Aug 2, 2022
Collaborator
nodejs-github-bot
commented
Aug 2, 2022
Collaborator
targos
approved these changes
Aug 2, 2022
F3n67u
approved these changes
Aug 2, 2022
targos
commented
Aug 2, 2022
Member
Landed in a8c2418...7a5de2c |
targos pushed a commit
that referenced
this pull request
Aug 2, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43885 Backport-PR-URL: #44082Fixes: #40678 Refs: #43514 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
This was referenced Aug 3, 2022
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This implements the Web API `CustomEvent` in `internal/event_target`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#43514 Backport-PR-URL: nodejs/node#44082 Refs: nodejs/node#40678 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#43885 Backport-PR-URL: nodejs/node#44082Fixes: nodejs/node#40678 Refs: nodejs/node#43514 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of:
CustomEvent#43514CustomEventon the global scope via a CLI flag #43885