Uh oh!
There was an error while loading. Please reload this page.
stream: update TextEncoderStream to align with the latest spec - #44101
Merged
Conversation
aduh95
reviewed
Aug 2, 2022
Comment on lines
6
to
7
Contributor
There was a problem hiding this comment.
Suggested change
| Uint8Array, | |
| String | |
| String, | |
| Uint8Array, |
MemberAuthor
There was a problem hiding this comment.
Done f2304b604d40fab394a3cbc81a04ed1d28dfa4b5
benjamingr
approved these changes
Aug 2, 2022
cola119force-pushed
the
update-encoder-spec
branch
from
August 3, 2022 00:31
f2304b6 to
03412dcCompareaduh95
reviewed
Aug 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
cola119force-pushed
the
update-encoder-spec
branch
from
August 3, 2022 09:15
03412dc to
c44d983Compareaduh95
reviewed
Aug 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
aduh95
approved these changes
Aug 3, 2022
nodejs-github-bot
commented
Aug 3, 2022
Collaborator
nodejs-github-bot
commented
Aug 3, 2022
Collaborator
nodejs-github-bot
commented
Aug 4, 2022
Collaborator
nodejs-github-bot
commented
Aug 4, 2022
Collaborator
Landed in c8bea71 |
This was referenced Aug 5, 2022
danielleadams pushed a commit
that referenced
this pull request
Aug 16, 2022
PR-URL: #44101 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit
that referenced
this pull request
Aug 23, 2022
PR-URL: #44101 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol
commented
Sep 29, 2022
Member
This is causing "wpt" tests in v16.x to fail. I will add the backport layer to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updated
TextEncoderStreamimplementation to align with the latest WHATWG spec.transform(): https://encoding.spec.whatwg.org/#encode-and-enqueue-a-chunkflush: https://encoding.spec.whatwg.org/#encode-and-flushTest cases of
/test/fixtures/wpt/encoding/streams/encode-utf8.any.js(WPT forTextEncoderStream) are all passed now. (The previous implementation didn't support surrogate pairs.)