Uh oh!
There was an error while loading. Please reload this page.
test: use addon.md block headings as test dir names - #4412
Closed
rvagg wants to merge 0 commit into
Closed
Conversation
rvagg
commented
Dec 24, 2015
MemberAuthor
rvagg
commented
Jan 13, 2016
MemberAuthor
ping @nodejs/build, @nodejs/testing any thoughts on this? |
jasnell
commented
Jan 13, 2016
Member
LGTM but would like to have at least @jbergstroem and @Trott take a look |
Trott
commented
Jan 14, 2016
Member
Semi-rubber-stamp LGTM |
jbergstroem
commented
Jan 14, 2016
Member
LGTM with optional bonus nit. |
rvagg added a commit
that referenced
this pull request
Jan 14, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvaggforce-pushed
the
name-addon.md-test-directories
branch
from
January 14, 2016 11:05
44a666b to
3727ae0Comparervagg
commented
Jan 14, 2016
MemberAuthor
landed @ 3727ae0, thanks folks |
rvagg added a commit
that referenced
this pull request
Jan 14, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit
that referenced
this pull request
Jan 28, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit
that referenced
this pull request
Feb 11, 2016
instead of doc-* PR-URL: #4412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
instead of doc-* PR-URL: nodejs#4412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Merged
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
instead of doc-* PR-URL: nodejs#4412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
instead of doc-* PR-URL: nodejs#4412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #4411 (includes the commit from there), but not urgent and not absolutely necessary. Instead of naming the directories doc-X where X is an incrementing number, name them according to the section of the doc from which they come so when debugging you have a clue what it's doing! Requires touch a lot of stuff, I hope I'm not missing anything.
/cc @nodejs/build