bootstrap: check more metadata when loading the snapshot by joyeecheung · Pull Request #44132 · nodejs/node

joyeecheung · 2022-08-04T14:03:35Z

This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

nodejs-github-bot · 2022-08-04T14:03:40Z

Review requested:

@nodejs/startup

nodejs-github-bot · 2022-08-04T14:04:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45838/

joyeecheung · 2022-08-04T14:23:26Z

Oops, forgot to commit the tests.

nodejs-github-bot · 2022-08-04T14:23:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45840/

joyeecheung · 2022-08-05T12:53:08Z

Fixed a bug for cross-compiled binaries.

nodejs-github-bot · 2022-08-05T12:53:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45863/

nodejs-github-bot · 2022-08-08T11:50:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45918/

This patch stores the metadata about the Node.js binary into the SnapshotData and adds fields denoting how the snapshot was generated, on what platform it was generated as well as the V8 cached data version flag. Instead of simply crashing when the metadata doesn't match, Node.js now prints an error message and exit with 1 for the customized snapshot, or ignore the snapshot and start from scratch if it's the default one.

…snapshot

joyeecheung · 2022-08-08T18:47:32Z

Rebased to resolve conflict with #44121

nodejs-github-bot · 2022-08-08T18:48:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45932/

nodejs-github-bot · 2022-08-09T08:52:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45943/

nodejs-github-bot · 2022-08-09T18:01:04Z

Landed in 5291096

This patch stores the metadata about the Node.js binary into the SnapshotData and adds fields denoting how the snapshot was generated, on what platform it was generated as well as the V8 cached data version flag. Instead of simply crashing when the metadata doesn't match, Node.js now prints an error message and exit with 1 for the customized snapshot, or ignore the snapshot and start from scratch if it's the default one. PR-URL: #44132 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

ruyadorno · 2022-08-22T21:36:35Z

hi @joyeecheung, unfortunately 5291096 is not landing cleanly in the updated v18.x-staging branch.

This PR will need to be backported in order to land in a v18.x release 😊

This patch stores the metadata about the Node.js binary into the SnapshotData and adds fields denoting how the snapshot was generated, on what platform it was generated as well as the V8 cached data version flag. Instead of simply crashing when the metadata doesn't match, Node.js now prints an error message and exit with 1 for the customized snapshot, or ignore the snapshot and start from scratch if it's the default one. PR-URL: nodejs#44132 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

joyeecheung · 2022-08-25T16:02:33Z

This depends on #44121, so needs to be backported after #44358

juanarbol · 2022-10-02T23:29:52Z

hi @joyeecheung, unfortunately 5291096 is not landing cleanly in the updated v18.x-staging branch.
This PR will need to be backported in order to land in a v18.x release blush

Same thing for the v16.x branch

This patch stores the metadata about the Node.js binary into the SnapshotData and adds fields denoting how the snapshot was generated, on what platform it was generated as well as the V8 cached data version flag. Instead of simply crashing when the metadata doesn't match, Node.js now prints an error message and exit with 1 for the customized snapshot, or ignore the snapshot and start from scratch if it's the default one. PR-URL: nodejs#44132 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

This patch stores the metadata about the Node.js binary into the SnapshotData and adds fields denoting how the snapshot was generated, on what platform it was generated as well as the V8 cached data version flag. Instead of simply crashing when the metadata doesn't match, Node.js now prints an error message and exit with 1 for the customized snapshot, or ignore the snapshot and start from scratch if it's the default one. PR-URL: #44132 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 4, 2022

addaleax approved these changes Aug 4, 2022
View reviewed changes

github-actionsBot mentioned this pull request Aug 5, 2022
CI Reliability 2022-08-05 nodejs/reliability#337
Open
17 tasks

legendecas approved these changes Aug 5, 2022
View reviewed changes

joyeecheung commented Aug 5, 2022
View reviewed changes

Comment threadsrc/node.cc Outdated
joyeecheungAug 5, 2022
Copy link
Copy Markdown
MemberAuthor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed a bug for cross-compiled binaries.

This was referenced Aug 6, 2022
CI Reliability 2022-08-06 nodejs/reliability#338
Open
CI Reliability 2022-08-07 nodejs/reliability#339
Open
CI Reliability 2022-08-08 nodejs/reliability#340
Open

joyeecheung added 4 commits August 9, 2022 02:42

fixup! bootstrap: check more metadata when loading the snapshot
3b83287

fixup! fixup! bootstrap: check more metadata when loading the snapshot
6f4a5e7

fixup! fixup! fixup! bootstrap: check more metadata when loading the …
76ec477
…snapshot

joyeecheung force-pushed the snapshot-metadata branch from f7fb91e to 76ec477Compare August 8, 2022 18:47

joyeecheung added the snapshot Issues and PRs related to the startup snapshot label Aug 8, 2022

github-actionsBot mentioned this pull request Aug 9, 2022
CI Reliability 2022-08-09 nodejs/reliability#341
Open
8 tasks

addaleax approved these changes Aug 9, 2022
View reviewed changes

joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 9, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2022

nodejs-github-bot merged commit 5291096 into nodejs:mainAug 9, 2022

github-actionsBot mentioned this pull request Aug 10, 2022
CI Reliability 2022-08-10 nodejs/reliability#342
Open
7 tasks

legendecas mentioned this pull request Aug 10, 2022
src: iterate over base objects to prepare for snapshot #44192
Merged

This was referenced Aug 11, 2022
CI Reliability 2022-08-11 nodejs/reliability#343
Open
CI Reliability 2022-08-12 nodejs/reliability#344
Open
CI Reliability 2022-08-13 nodejs/reliability#345
Open

danielleadams mentioned this pull request Aug 16, 2022
v18.8.0 release proposal #44246
Closed

ruyadorno added the backport-requested-v18.x label Aug 22, 2022

joyeecheung mentioned this pull request Aug 25, 2022
src: fix cppgc incompatibility in v8 #43521
Closed

juanarbol added the backport-requested-v16.x label Oct 2, 2022

RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged

joyeecheung mentioned this pull request Oct 14, 2022
src: consolidate exit codes in the code base #44746
Merged

joyeecheung mentioned this pull request Oct 14, 2022
[v18.x] backport various patches of internal refactorings for snapshot and realms #45007
Closed

danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged

Uh oh!

Uh oh!

Conversation

joyeecheung commented Aug 4, 2022

Uh oh!

nodejs-github-bot commented Aug 4, 2022

Uh oh!

nodejs-github-bot commented Aug 4, 2022

Uh oh!

joyeecheung commented Aug 4, 2022

Uh oh!

nodejs-github-bot commented Aug 4, 2022

Uh oh!

joyeecheungAug 5, 2022

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 5, 2022

Uh oh!

nodejs-github-bot commented Aug 8, 2022

Uh oh!

joyeecheung commented Aug 8, 2022

Uh oh!

nodejs-github-bot commented Aug 8, 2022

Uh oh!

nodejs-github-bot commented Aug 9, 2022

Uh oh!

nodejs-github-bot commented Aug 9, 2022

Uh oh!

ruyadorno commented Aug 22, 2022

Uh oh!

joyeecheung commented Aug 25, 2022

Uh oh!

juanarbol commented Oct 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants