Skip to content

test: add OpenSSL 3.x providers test - #44148

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:ossl3providers
Aug 24, 2022
Merged

test: add OpenSSL 3.x providers test#44148
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:ossl3providers

Conversation

@richardlau

Copy link
Copy Markdown
Member

Add basic tests for providers when using OpenSSL 3.x.


Intent is to add these basic tests and then extend in a follow up PR to cover e.g. fips.

cc @nodejs/crypto

Add basic tests for providers when using OpenSSL 3.x.
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 5, 2022
@richardlaurichardlau added crypto Issues and PRs related to the crypto subsystem. openssl Issues and PRs related to the OpenSSL dependency. labels Aug 5, 2022
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added the review wanted PRs that need reviews. label Aug 11, 2022

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 53ec358 into nodejs:mainAug 24, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 53ec358

RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
Add basic tests for providers when using OpenSSL 3.x.
PR-URL: #44148
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Sep 5, 2022
richardlau added a commit to richardlau/node-1 that referenced this pull request Sep 28, 2022
IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.
Refs: nodejs#31967
Refs: nodejs#44148
@richardlaurichardlau mentioned this pull request Sep 29, 2022
4 tasks
@juanarbol

Copy link
Copy Markdown
Member

Node.js v16.x uses OpenSSL 1.1.1q+quic

nodejs-github-bot pushed a commit that referenced this pull request Oct 2, 2022
IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.
Refs: #31967
Refs: #44148
PR-URL: #44810
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.
Refs: #31967
Refs: #44148
PR-URL: #44810
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addonsIssues and PRs related to native addons.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.opensslIssues and PRs related to the OpenSSL dependency.review wantedPRs that need reviews.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@richardlau@nodejs-github-bot@juanarbol@mhdawson@RafaelGSS