Uh oh!
There was an error while loading. Please reload this page.
[v18.x] src: split property helpers from node::Environment - #44251
Closed
legendecas wants to merge 1 commit into
Closed
[v18.x] src: split property helpers from node::Environment#44251legendecas wants to merge 1 commit into
legendecas wants to merge 1 commit into
Conversation
nodejs-github-bot
commented
Aug 16, 2022
Collaborator
Review requested:
|
legendecas
commented
Aug 16, 2022
MemberAuthor
/cc @danielleadams |
legendecas
commented
Aug 16, 2022
MemberAuthor
The file that linter is complaining about is not changed in this PR. I'll leave it to releasers to determine what to do with the staging branch. |
danielleadamsforce-pushed
the
v18.x-staging
branch
from
August 17, 2022 01:16
96c3373 to
e028edbComparedanielleadams
commented
Aug 17, 2022
Contributor
Hi @legendecas - I had to update v18.x-staging, so this will need a rebase |
PR-URL: nodejs#44056 Refs: nodejs#42528 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
legendecasforce-pushed
the
backport-44056-to-18
branch
from
August 17, 2022 13:02
b956ac4 to
aed3566Comparelegendecas
commented
Aug 17, 2022
MemberAuthor
@danielleadams rebased. |
ruyadorno
approved these changes
Aug 21, 2022
ruyadorno
commented
Aug 21, 2022
Member
Landed in 68ee8e9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #44056
Refs: #42528
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Feng Yu F3n67u@outlook.com