Uh oh!
There was an error while loading. Please reload this page.
[v18.x backport] lib: add diagnostics channel and perf hooks detail - #44256
Closed
theanarkh wants to merge 1 commit into
Closed
[v18.x backport] lib: add diagnostics channel and perf hooks detail#44256theanarkh wants to merge 1 commit into
theanarkh wants to merge 1 commit into
Conversation
nodejs-github-bot
commented
Aug 16, 2022
Collaborator
Review requested:
|
theanarkhforce-pushed
the
backport-43984-to-v18.x
branch
from
August 16, 2022 18:50
2f96247 to
7de711eComparedanielleadamsforce-pushed
the
v18.x-staging
branch
from
August 17, 2022 01:16
96c3373 to
e028edbComparedanielleadams
commented
Aug 17, 2022
Contributor
@theanarkh apologies, but I had to update v18.x-staging, so this will need a rebase. |
theanarkhforce-pushed
the
backport-43984-to-v18.x
branch
3 times, most recently
from
August 17, 2022 03:43
62e2bbd to
8cbe1a7ComparePR-URL: nodejs#43984 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com Reviewed-By: Minwoo Jung nodecorelab@gmail.com
theanarkhforce-pushed
the
backport-43984-to-v18.x
branch
from
August 17, 2022 03:57
8cbe1a7 to
cf057b4Comparetheanarkh
commented
Aug 17, 2022
ContributorAuthor
Done, please help review. |
Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
left a comment
Member
There was a problem hiding this comment.
The current commit as a backport LGTM, though @danielleadams should we add another commit from #44144 together in this PR to prevent the tests from flaking?
theanarkh
commented
Aug 17, 2022
ContributorAuthor
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
36 tasks
nodejs-github-bot
commented
Aug 22, 2022
Collaborator
ruyadorno
commented
Aug 23, 2022
Member
Landed in 1a44fbc |
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Co-Authored-By: theanarkh <theratliter@gmail.com> PR-URL: nodejs/node#43984 Backport-PR-URL: nodejs/node#44256 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com Reviewed-By: Minwoo Jung nodecorelab@gmail.com
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Co-Authored-By: theanarkh <theratliter@gmail.com> PR-URL: nodejs/node#43984 Backport-PR-URL: nodejs/node#44256 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com Reviewed-By: Minwoo Jung nodecorelab@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #43984
cc @joyeecheung Can you help review the change of
net.js? Thanks !Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com