Skip to content

doc: enrich test commands with executable - #44347

Merged
nodejs-github-bot merged 10 commits into
nodejs:mainfrom
tony-go:run-test-doc
Feb 6, 2023
Merged

doc: enrich test commands with executable#44347
nodejs-github-bot merged 10 commits into
nodejs:mainfrom
tony-go:run-test-doc

Conversation

@tony-go

@tony-gotony-go commented Aug 22, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Hey 👋

A tiny pull request to enrich test commands in the documentation.

cc @arkerone

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 22, 2022
tony-go
tony-go commented Aug 22, 2022
View reviewed changes
Comment threadBUILDING.md Outdated
@tony-go
tony-go marked this pull request as ready for review August 23, 2022 15:16
aduh95
aduh95 reviewed Aug 23, 2022
View reviewed changes
Comment threadBUILDING.md
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
@tony-go
tony-go requested a review from aduh95August 24, 2022 06:38
aduh95
aduh95 reviewed Aug 24, 2022
View reviewed changes
Comment threadBUILDING.md Outdated
RaisinTen
RaisinTen reviewed Aug 24, 2022
View reviewed changes
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
@tony-go
tony-go requested review from RaisinTen and aduh95 and removed request for RaisinTen and aduh95August 24, 2022 16:53
RaisinTen
RaisinTen approved these changes Aug 25, 2022
View reviewed changes

@RaisinTenRaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be nice if you could also include the reasoning (#44347 (comment)) in the description

RaisinTen
RaisinTen reviewed Aug 26, 2022
View reviewed changes

@RaisinTenRaisinTen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #44407 lands, tools/test.py should work without explicitly writing out the command name. Calling it like python ... would only be required on Windows.

@himself65himself65 mentioned this pull request Sep 6, 2022
Merged
@tony-go
tony-go requested a review from aduh95September 7, 2022 05:24
@tony-go

tony-go commented Feb 4, 2023

Copy link
Copy Markdown
MemberAuthor

@RaisinTen I finally updated the doc, could PTAL ^^

@tony-go
tony-go requested review from RaisinTen and removed request for aduh95February 4, 2023 11:36
richardlau
richardlau reviewed Feb 4, 2023
View reviewed changes
Comment threadBUILDING.md Outdated
@tony-go
tony-go requested review from richardlau and removed request for RaisinTenFebruary 5, 2023 15:32
@tony-go

tony-go commented Feb 5, 2023

Copy link
Copy Markdown
MemberAuthor

Finally, remove the python exec from examples and add a note for windows.

RaisinTen
RaisinTen approved these changes Feb 6, 2023
View reviewed changes

@RaisinTenRaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2023
@RaisinTenRaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 6, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 2dacd07 into nodejs:mainFeb 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2dacd07

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@tony-go@MylesBorins
doc: enrich test command with executable
a7beac0
PR-URL: #44347
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tony-go@danielleadams
doc: enrich test command with executable
f1de3f7
PR-URL: #44347
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@jasnelljasnelljasnell approved these changes
@richardlaurichardlaurichardlau approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tony-go@nodejs-github-bot@jasnell@richardlau@aduh95@RaisinTen