Uh oh!
There was an error while loading. Please reload this page.
[v16.x] build: add windows-2022 to v16.x actions - #44365
Closed
dennisameling wants to merge 1 commit into
Closed
Conversation
This was reverted in the commit mentioned below due to a compiler bug. The bug got resolved in MSVC 14.33, which is part of the GitHub Actions 20220821.1 image for windows-2022. Ref: 79e2ab2 Ref: #42560 Ref: https://developercommunity.visualstudio.com/t/Failed-to-compile-nodejs-16140-with-la/1682115?space=62&q=nodejs Ref: https://github.com/actions/runner-images/blob/releases/win22/20220821/images/win/Windows2022-Readme.md
nodejs-github-bot
commented
Aug 23, 2022
Collaborator
Review requested:
|
This was referenced Aug 23, 2022
aduh95
commented
Aug 23, 2022
Contributor
I think that should land on |
richardlau
commented
Aug 23, 2022
Member
|
| jobs: | ||
| coverage-windows: | ||
| if: github.event.pull_request.draft == false | ||
| runs-on: windows-2019 |
Member
There was a problem hiding this comment.
I think this should stays on windows-2019 since this need a more stable build env. As my experience, MSVC stability can't be guaranteed and take way to many time to fix.
ruyadornoforce-pushed
the
v16.x-staging
branch
from
September 23, 2022 15:59
541252d to
c1c8b6dComparejuanarbolforce-pushed
the
v16.x-staging
branch
4 times, most recently
from
October 10, 2022 23:49
02cd9a9 to
54b9635Comparedennisameling
commented
Jan 28, 2023
ContributorAuthor
Closing in favor of #46228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#42560
This was reverted in the commit mentioned below due to a compiler bug. The bug got resolved in MSVC 14.33, which is part of the GitHub Actions 20220821.1 image for windows-2022.
Note that I'm not adding this to the
mainbranch yet as there's a separate issue there: #43092Ref: 79e2ab2
Ref: #42560
Ref: https://developercommunity.visualstudio.com/t/Failed-to-compile-nodejs-16140-with-la/1682115?space=62&q=nodejs
Ref: https://github.com/actions/runner-images/blob/releases/win22/20220821/images/win/Windows2022-Readme.md