Skip to content

doc: improvements to dns.markdown copy - #4449

Closed
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:doc-dns-improvements
Closed

doc: improvements to dns.markdown copy#4449
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:doc-dns-improvements

Conversation

@jasnell

Copy link
Copy Markdown
Member

General improvements to dns.markdown copy and examples

General improvements to dns.markdown copy and examples
@jasnelljasnell added doc Issues and PRs related to the documentations. dns Issues and PRs related to the dns subsystem. labels Dec 28, 2015
Comment threaddoc/api/dns.markdown Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove another

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol... sigh.

@jasnell

Copy link
Copy Markdown
MemberAuthor

@silverwind ... pushed some updates and added some comments. PTAL

@silverwind

Copy link
Copy Markdown
Contributor

LGTM

Comment threaddoc/api/dns.markdown Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove currently

@jasnell

Copy link
Copy Markdown
MemberAuthor

@Trott ... fixed!

@Qard

Qard commented Dec 29, 2015

Copy link
Copy Markdown
Member

LGTM

jasnell added a commit that referenced this pull request Dec 30, 2015
General improvements to dns.markdown copy and examples
PR-URL: #4449
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 7ee1685

@jasnelljasnell closed this Dec 30, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
General improvements to dns.markdown copy and examples
PR-URL: nodejs#4449
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
General improvements to dns.markdown copy and examples
PR-URL: #4449
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
General improvements to dns.markdown copy and examples
PR-URL: #4449
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
General improvements to dns.markdown copy and examples
PR-URL: nodejs#4449
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dnsIssues and PRs related to the dns subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@silverwind@Qard@aredridel@Trott@MylesBorins