Uh oh!
There was an error while loading. Please reload this page.
doc: improvements to events.markdown copy - #4468
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
MylesBorins
commented
Dec 29, 2015
Contributor
LGTM My only comment is that it seems like the first example might have too much inheritance logic that the basic emitter logic could be lost on a newer developer. Perhaps the first example should simply show setting up an instance of emitter? |
Qard
commented
Dec 30, 2015
Member
One minor nit, but LGTM other than that. |
jasnell
commented
Dec 30, 2015
MemberAuthor
@thealphanerd ... given that inheriting from |
General improvements to events.markdown copy including a bit of restructuring and improved examples
jasnellforce-pushed
the
doc-events-improvements
branch
from
December 30, 2015 18:46
203d1cd to
abdc464Comparejasnell
commented
Dec 30, 2015
MemberAuthor
@Qard ... nit addressed. |
Qard
commented
Dec 30, 2015
Member
LGTM |
MylesBorins
commented
Dec 30, 2015
Contributor
@jasnell that is reasonable enough, and how it was done before. LGTM |
jasnell added a commit
that referenced
this pull request
Dec 30, 2015
General improvements to events.markdown copy including a bit of restructuring and improved examples PR-URL: #4468 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
jasnell
commented
Dec 30, 2015
MemberAuthor
Landed in a0130e1 |
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
General improvements to events.markdown copy including a bit of restructuring and improved examples PR-URL: nodejs#4468 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 13, 2016
General improvements to events.markdown copy including a bit of restructuring and improved examples PR-URL: #4468 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
General improvements to events.markdown copy including a bit of restructuring and improved examples PR-URL: #4468 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Merged
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
General improvements to events.markdown copy including a bit of restructuring and improved examples PR-URL: nodejs#4468 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General improvements to events.markdown copy including a
bit of restructuring and improved examples