net: add autoSelectFamily option

[ShogunPanda]

This PR loosely implements section 5 of RFC 8305 (Happy Eyeballs algorithm).

A new option autoSelectFamily is added to net.connect.
When set to a positive number (or true), the lookup phase will keep all records by setting all=true.
A connection attempt will be tried to all AAAA and A records (alternating families), in sequence, giving each connection autoSelectFamily milliseconds to be established.
Errors are raised only if no connection succeeded.

Fixes#41625.

[nodejs-github-bot]

Review requested:

• @nodejs/net

[mcollina]

Can you please add a test for HTTPs too?

[mcollina]

@nodejs/tsc this is a notable change that we should land before v18 goes LTS. We have seen quite a few reports of bugs due to improper configuration of IPv6, making #41625 a necessity. For example, Docker on Mac only exposes ports on the IPv4 address, making all connections to localhost fail.

[Trott]

No comment (yet at least) one way or the other on the implementation, but +1000 to implementing happy eyeballs in Node.js.

[richardlau]

The two new tests fail for me (Linux x64) and also in GitHub actions.

Details

=== release test-http-happy-eyeballs ===
Path: parallel/test-http-happy-eyeballs
Error: --- stderr ---
node:events:491
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE: address already in use :::33167
at Server.setupListenHandle [as _listen2] (node:net:1649:16)
at listenInCluster (node:net:1697:12)
at doListen (node:net:1846:7)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on Server instance at:
at emitErrorNT (node:net:1676:8)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'EADDRINUSE',
errno: -98,
syscall: 'listen',
address: '::',
port: 33167
}
Node.js v19.0.0-pre
Command: out/Release/node /home/runner/work/node/node/test/parallel/test-http-happy-eyeballs.js
=== release test-net-happy-eyeballs ===
Path: parallel/test-net-happy-eyeballs
Error: --- stderr ---
node:events:491
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE: address already in use :::37301
at Server.setupListenHandle [as _listen2] (node:net:1649:16)
at listenInCluster (node:net:1697:12)
at doListen (node:net:1846:7)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on Server instance at:
at emitErrorNT (node:net:1676:8)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'EADDRINUSE',
errno: -98,
syscall: 'listen',
address: '::',
port: 37301
}
Node.js v19.0.0-pre
Command: out/Release/node /home/runner/work/node/node/test/parallel/test-net-happy-eyeballs.js
===
=== 2 tests failed
===

[ShogunPanda]

Acknowledged!
I'm taking care of them locally.

[mhdawson]

No comment (yet at least) one way or the other on the implementation, but +1000 to implementing happy eyeballs in Node.js.

Same goes for me as well.

[aduh95]

Can we add test for dnsPromises.Resolver as well?

[Trott]

we should land before v18 goes LTS

@nodejs/tsc Two comments.

1. If I understand correctly, this is a breaking change. It should be semver major.EDIT: Oh, wait, this is an option that is off by default? So people would need to opt in to get the fix? Oh, then I can't imagine this is controversial at all. Yes, let's get this working and landed! Woo hoo! 🎉 🚀
2. However...I am in favor of landing this in the 18.x line as a special case of an important bug fix. Specifically:

Docker on Mac only exposes ports on the IPv4 address, making all connections to localhost fail.

[Trott]

I'm going to rebase and force push to at least get the tarball job working.

[mcollina]

Oh, wait, this is an option that is off by default? So people would need to opt in to get the fix?

My case is that we should make it enabled by default. This causes so many headaches to newbie developers that know little of IPv4 vs IPv6 and why localhost is two IPs.

We should make this change before v18 goes LTS.

[vidddd1]