Uh oh!
There was an error while loading. Please reload this page.
test: don't use cwd for relative path - #4477
Conversation
jbergstroem
commented
Dec 30, 2015
CI: https://ci.nodejs.org/job/node-test-commit/1571/ Will likely get a fail on raspberry pi because the path to common pipe will be too long. A fix for that would either be making it flaky for a while ("fix") or changing the temporary path which we explore through #4476. |
jbergstroem
commented
Dec 30, 2015
@Trott mentions that this actually doesn't properly address relative tests. Will address shortly. |
Trott
commented
Dec 30, 2015
LGTM if CI is happy (or happier) |
jbergstroem
commented
Dec 30, 2015
New CI here: https://ci.nodejs.org/job/node-test-commit/1572/ |
Trott
commented
Dec 30, 2015
Bonus benefit is that you can run this with CWD of |
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: nodejs#4477 Reviewed-By: Rich Trott <rtrott@gmail.com>
ccc802d to
6efa031CompareWith the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: nodejs#4477 Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
commented
Jan 15, 2016
@thealphanerd This will need land on v4.x-staging since #3325 has landed and made the temp dir customizable via NODE_TEST_DIR while removing NODE_COMMON_PIPE. |
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: #4477 Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
commented
Jan 15, 2016
Landed in v4.x-staging in bb2e2d0 |
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: #4477 Reviewed-By: Rich Trott <rtrott@gmail.com>
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: nodejs#4477 Reviewed-By: Rich Trott <rtrott@gmail.com>
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code.
/R=@Trott?