Skip to content

meta: fix test_runner labeling - #44863

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-labels
Oct 2, 2022
Merged

meta: fix test_runner labeling#44863
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-labels

Conversation

@MoLow

@MoLowMoLow commented Oct 2, 2022•
edited
Loading

Copy link
Copy Markdown
Member

there are 3 issues fixed by this PR (I tested the changes locally)

  1. doc/api/test.md was converted to testIssues and PRs related to the tests. instead of test_runnerIssues and PRs related to the test runner subsystem.
  2. lib/test.js was converted to testIssues and PRs related to the tests. instead of test_runnerIssues and PRs related to the test runner subsystem.
  3. lib/internal/test_runner/* only adds https://github.com/nodejs/node/labels/dont-land-on-v14.x but does not add test_runnerIssues and PRs related to the test runner subsystem. (caused by meta: update test_runner in label-pr-config #44615)

examples:
#44854
#44844

the third issue did not occur yet so there is no example for it

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 2, 2022
@MoLow

MoLow commented Oct 2, 2022

Copy link
Copy Markdown
MemberAuthor

CC @nodejs/test_runner

@MoLowMoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 2, 2022
@github-actions

github-actionsBot commented Oct 2, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit e5c807e into nodejs:mainOct 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in e5c807e

@MoLow
MoLow deleted the fix-test-runner-labels branch October 2, 2022 11:19
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@MoLow@danielleadams
meta: label test.js and test.md with test_runner label
2efe4d9
PR-URL: #44863
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MoLow@nodejs-github-bot@jasnell@RaisinTen