Uh oh!
There was an error while loading. Please reload this page.
[v16.x backport] test runner additions - #44873
Closed
MoLow wants to merge 6 commits into
Closed
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
targos
commented
Oct 3, 2022
Member
If possible, we prefer to keep separated commits in backports, so we know from the git log what landed in the release line |
MoLowforce-pushed
the
backport-v16-test-runner
branch
from
October 3, 2022 10:15
b6d316e to
f44fcd9CompareMoLow
commented
Oct 3, 2022
MemberAuthor
@targos I am not sure what you meant - but you commented before I have committed. I just wanted to have a backport pr URL before cherry-picking the relevant commits. |
MoLow
marked this pull request as ready for review
October 3, 2022 10:16
targos
commented
Oct 3, 2022
Member
@MoLow Looks like I was too fast indeed. This looks ok 👍🏻 (btw, you can add the Backport-PR-URL yourself, but that would be already done automatically when we land it with |
MoLowforce-pushed
the
backport-v16-test-runner
branch
from
October 3, 2022 11:31
f44fcd9 to
d351059CompareMoLow
commented
Oct 3, 2022
MemberAuthor
v16 linter seems broken regardless of this PR |
MoLowforce-pushed
the
backport-v16-test-runner
branch
from
October 3, 2022 13:08
d351059 to
23ab7feCompareMember
@juanarbol it seems to be broken since the last push to |
PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44873Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44592 Backport-PR-URL: nodejs#44873 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLowforce-pushed
the
backport-v16-test-runner
branch
from
November 23, 2022 22:46
ea19306 to
36be71eComparenodejs-github-bot
commented
Nov 23, 2022
Collaborator
MoLow
commented
Nov 24, 2022
MemberAuthor
@richardlau CI is running #44873 (comment) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Nov 24, 2022
Collaborator
This was referenced Nov 25, 2022
nodejs-github-bot
commented
Nov 27, 2022
Collaborator
This was referenced Nov 28, 2022
This was confirmed flaky on those platforms: - Windows x64 - Windows on Arm - Linux - Freebsd Tests randomly fail because of bad order in messages expected, which seems related to threads scheduling at execution. PR-URL: nodejs#45049 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
commented
Nov 30, 2022
Collaborator
10 tasks
nodejs-github-bot
commented
Dec 1, 2022
Collaborator
MoLow
commented
Dec 1, 2022
MemberAuthor
@richardlau can this be merged? |
This was referenced Dec 2, 2022
richardlau
approved these changes
Dec 7, 2022
richardlau
commented
Dec 7, 2022
Member
Landed in 5a776d4...821d832. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports:
--test#44241duration_msto be milliseconds #44450--inspectwith--test#44520