Skip to content

doc,crypto: mark experimental algorithms more visually - #44892

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-api-experimental
Oct 6, 2022
Merged

doc,crypto: mark experimental algorithms more visually#44892
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:webcrypto-api-experimental

Conversation

@panva

@panvapanva commented Oct 4, 2022

Copy link
Copy Markdown
Member

Similar to #44588 this adds a Stability index color-coded indicator to experimental WebCryptoAPI algorithms' documentation.

🖼️ Dark mode - tableScreenshot 2022-10-04 at 14 21 10
🖼️ Light mode - tableScreenshot 2022-10-04 at 14 20 14
🖼️ Dark mode - listScreenshot 2022-10-04 at 14 20 56
🖼️ Light mode - listScreenshot 2022-10-04 at 14 20 32

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 4, 2022
@panvapanva added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. webcrypto and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 4, 2022
@nodejsnodejs deleted a comment from nodejs-github-botOct 4, 2022
@panva

panva commented Oct 4, 2022

Copy link
Copy Markdown
MemberAuthor

Review requested:

  • @nodejs/crypto
  • @nodejs/documentation

@Trott

Trott commented Oct 5, 2022

Copy link
Copy Markdown
Member

I pulled these changes in and used a tool to check the resulting HTML for accessibility-related color contrast issues and there weren't any. 👍 Looks good to me.

@panva
panva marked this pull request as ready for review October 5, 2022 12:01
@panva
panvaforce-pushed the webcrypto-api-experimental branch from 6534dee to b9d74e0CompareOctober 5, 2022 12:01
@panva
panva requested a review from TrottOctober 5, 2022 12:02
@panva
panvaforce-pushed the webcrypto-api-experimental branch from b9d74e0 to 555466eCompareOctober 5, 2022 12:11
@aymen94

Copy link
Copy Markdown
Member

LGTM

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 5, 2022
@Trott

Trott commented Oct 6, 2022

Copy link
Copy Markdown
Member

FYI for @nodejs/website @nodejs/nodejs-dev in case these kinds of things might affect the website in ways I'm not aware of.

@ovflowd

Copy link
Copy Markdown
Member

For nodejs.dev this change would not create any issues afaik.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit aacd742 into nodejs:mainOct 6, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in aacd742

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Oct 11, 2022
@panva
panva deleted the webcrypto-api-experimental branch October 13, 2022 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.experimentalIssues and PRs related to experimental features.webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@Trott@aymen94@ovflowd@nodejs-github-bot@lpinca