Uh oh!
There was an error while loading. Please reload this page.
test: refactor test-fs-empty-readStream - #4490
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: nodejs#4476 (comment)
Trott
commented
Dec 30, 2015
MemberAuthor
cjihrig
commented
Dec 30, 2015
Contributor
LGTM if the CI is happy. |
Trott
commented
Dec 30, 2015
MemberAuthor
Unrelated semi-known* flaky test failure on FreeBSD and a brand new unrelated test failure on SmartOS, but other than that, CI looks good. The modified test is passing everywhere.
|
jbergstroem
commented
Dec 31, 2015
Member
Trott
commented
Dec 31, 2015
MemberAuthor
Trott
commented
Dec 31, 2015
MemberAuthor
@jbergstroem Still lots of failures in the parallelizing WIP stuff (no surprise there) but not this test, so hooray I guess. |
jbergstroem
commented
Dec 31, 2015
Member
@Trott another one bites the dust. LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jan 2, 2016
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: nodejs#4476 (comment) PR-URL: nodejs#4490 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott
commented
Jan 2, 2016
MemberAuthor
Landed in 44ed999 |
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: nodejs#4476 (comment) PR-URL: nodejs#4490 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 13, 2016
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: #4476 (comment) PR-URL: #4490 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 14, 2016
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: #4476 (comment) PR-URL: #4490 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: #4476 (comment) PR-URL: #4490 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Refactor test to remove unnecessary booleans and one unnecesary timer. Instead, throw Error objects where appropriate and rely on common.mustCall(). The timer seemed to be the source of an issue when parallelizing tests. Ref: nodejs#4476 (comment) PR-URL: nodejs#4490 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor test to remove unnecessary booleans and one unnecesary timer.
Instead, throw Error objects where appropriate and rely on
common.mustCall().
The timer seemed to be the source of an issue when parallelizing tests.
Ref: #4476 (comment)