Skip to content

crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey - #44917

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:fix-webcrypto-get-key-length
Oct 12, 2022
Merged

crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey#44917
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:fix-webcrypto-get-key-length

Conversation

@panva

@panvapanva commented Oct 7, 2022

Copy link
Copy Markdown
Member

#42542 unfortunately used the hash's output size instead of block size. This also fixes the same problem for HMAC generateKey when length is missing.

Screenshot 2022-10-08 at 1 07 33

Screenshot 2022-10-08 at 1 07 02

Refs: denoland/deno#16180 (comment)
Refs: cloudflare/workerd#68 (comment)

@panvapanva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto labels Oct 7, 2022
@panva
panva requested review from jasnell and tniessenOctober 7, 2022 23:15
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 7, 2022
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47119/

@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47120/

@panvapanva mentioned this pull request Oct 8, 2022
Merged
@panva
panvaforce-pushed the fix-webcrypto-get-key-length branch from f979ef3 to 7f2258fCompareOctober 10, 2022 07:46
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47149/

@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47151/

@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47155/

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2022
@github-actionsgithub-actionsBot mentioned this pull request Oct 11, 2022
Open
15 tasks
@panva
panvaforce-pushed the fix-webcrypto-get-key-length branch from 7f2258f to 472ae3aCompareOctober 12, 2022 10:55
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47214/

@panvapanva mentioned this pull request Oct 12, 2022
Merged
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47219/

@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47222/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 214354f into nodejs:mainOct 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Landed in 214354f

@panva
panva deleted the fix-webcrypto-get-key-length branch October 13, 2022 09:12
@github-actionsgithub-actionsBot mentioned this pull request Oct 18, 2022
Open
13 tasks
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva@danielleadams
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
2435a8f
PR-URL: #44917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva@danielleadams
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
57f507f
PR-URL: #44917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panvapanva mentioned this pull request Mar 31, 2023
Closed
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
@panva
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
ae600b9
PR-URL: nodejs#44917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Backport-PR-URL: nodejs#47336
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes
@tniessentniessenAwaiting requested review from tniessen

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.experimentalIssues and PRs related to experimental features.needs-ciPRs that need a full CI run.webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@jasnell@aduh95