Uh oh!
There was an error while loading. Please reload this page.
module: migrate to script context based host defined options - #44923
Closed
legendecas wants to merge 3 commits into
Closed
module: migrate to script context based host defined options#44923legendecas wants to merge 3 commits into
legendecas wants to merge 3 commits into
Conversation
nodejs-github-bot
commented
Oct 8, 2022
Collaborator
Review requested:
|
SimenB
commented
Oct 11, 2022
Member
I'm beyond happy to see movement on this issue more than a year and a half after it was pointed to as a blocker of stabilization of vm ESM 🎉 |
ywave620
commented
Oct 12, 2022
Contributor
Can this PR get landed before the v8 team decides to adopt your change? @legendecas |
legendecas
commented
Oct 12, 2022
MemberAuthor
@ywave620 that's not in accord with the working process. I don't think we should land this before the v8 CL gets landed first. |
targos
commented
Nov 8, 2022
Member
@legendecas What's the status on the V8 side? |
legendecas
commented
Nov 9, 2022
MemberAuthor
@targos thanks for the ping. I'll reach out to Camillo to see the next steps. |
This allows the host-defined options to be an arbitrary JavaScript value so that the module/script wrapper object can be used as the host-defined options instead. In this way, we can move away from the id-based module tables and fixes the problem that the scripts can out lives the module wrapper objects.
legendecasforce-pushed
the
vm/host-defined-options
branch
from
November 23, 2022 17:29
54f0d90 to
438df3bComparelegendecas
commented
Oct 23, 2023
MemberAuthor
#48510 fixed the crashes with an alternative approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready to be reviewed properly. Just a preview of the solution.
deps: v8: [runtime] Store host-defined options in the context
CR-URL: https://chromium-review.googlesource.com/c/v8/v8/+/3172764
module: migrate to script context based host defined options
This allows the host-defined options to be an arbitrary JavaScript value
so that the module/script wrapper object can be used as the host-defined
options instead. In this way, we can move away from the id-based module
tables and fixes the problem that the scripts can out lives the module
wrapper objects.
Fixes: #43681
Fixes: #43205
Fixes: #44438