Skip to content

test: improve test coverage in test-child-process-spawn-argv0.js - #44955

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
juanarbol:juan/cp-argv0-test-improvement
Oct 14, 2022
Merged

test: improve test coverage in test-child-process-spawn-argv0.js#44955
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
juanarbol:juan/cp-argv0-test-improvement

Conversation

@juanarbol

@juanarboljuanarbol commented Oct 10, 2022

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 10, 2022
@juanarboljuanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47274/

@juanarboljuanarbol added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 14, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 386d761 into nodejs:mainOct 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in 386d761

@juanarbol
juanarbol deleted the juan/cp-argv0-test-improvement branch October 24, 2022 13:48
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@juanarbol@RafaelGSS
test: improve test coverage in test-child-process-spawn-argv0.js
02a6a14
PR-URL: #44955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@juanarbol@RafaelGSS
test: improve test coverage in test-child-process-spawn-argv0.js
4825786
PR-URL: #44955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@juanarbol@danielleadams
test: improve test coverage in test-child-process-spawn-argv0.js
43f4ed5
PR-URL: #44955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@juanarbol@danielleadams
test: improve test coverage in test-child-process-spawn-argv0.js
dfc2419
PR-URL: #44955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juanarbol@nodejs-github-bot@lpinca@cjihrig@joyeecheung