Skip to content

meta: update AUTHORS - #45020

Merged
nodejs-github-bot merged 2 commits into
mainfrom
actions/authors-update
Oct 16, 2022
Merged

meta: update AUTHORS#45020
nodejs-github-bot merged 2 commits into
mainfrom
actions/authors-update

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Oct 16, 2022

Copy link
Copy Markdown
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.mjs.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 16, 2022
Trott
Trott reviewed Oct 16, 2022
View reviewed changes
Comment threadAUTHORS Outdated
Trott
Trott reviewed Oct 16, 2022
View reviewed changes
Comment threadAUTHORS Outdated
@TrottTrott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 16, 2022
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 16, 2022
@github-actions

github-actionsBot commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2022
@aduh95

aduh95 commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

@Trott

Trott commented Oct 16, 2022

Copy link
Copy Markdown
Member

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

Yeah, the output of tools/update-authors.mjs lists suspected duplicates already. See https://github.com/nodejs/node/actions/runs/3257704667/jobs/5349162871#step:3:5 for an example.

So it would just be a matter of detecting them and including them in the PR description or something like that.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 16, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 16, 2022
@nodejs-github-bot
nodejs-github-bot merged commit c0b5c36 into mainOct 16, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Landed in c0b5c36

@nodejs-github-bot
nodejs-github-bot deleted the actions/authors-update branch October 16, 2022 14:49
@aduh95

aduh95 commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

Yeah, the output of tools/update-authors.mjs lists suspected duplicates already. See https://github.com/nodejs/node/actions/runs/3257704667/jobs/5349162871#step:3:5 for an example.

So it would just be a matter of detecting them and including them in the PR description or something like that.

Or even simply liking to the workflow would already greatly simplify the review process, although your proposal seems of course even better if doable.

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@nodejs-github-bot@RafaelGSS
meta: update AUTHORS
c542af5
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@nodejs-github-bot@RafaelGSS
meta: update AUTHORS
7900810
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot@danielleadams
meta: update AUTHORS
4daf4ae
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nodejs-github-bot@danielleadams
meta: update AUTHORS
9ec6117
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@aduh95@Trott@lpinca@RaisinTen