Skip to content

test: Remove mention of --experimental-async-stack-tagging-api flag - #45051

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
szuend:remove-async-stack-tagging-api
Oct 18, 2022
Merged

test: Remove mention of --experimental-async-stack-tagging-api flag#45051
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
szuend:remove-async-stack-tagging-api

Conversation

@szuend

Copy link
Copy Markdown
Contributor

The flag was enabled by default with V10.6 (https://crrev.com/c/3809692) and we plan to remove the flag now in time for V8 10.9.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2022
@szuend
szuendforce-pushed the remove-async-stack-tagging-api branch from 8630231 to 0a3e3e7CompareOctober 18, 2022 08:55
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 changed the title test: Remove mention of --experimanl-async-stack-tagging-api flagtest: Remove mention of --experimental-async-stack-tagging-api flagOct 18, 2022
@aduh95aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 18, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 90044f5 into nodejs:mainOct 18, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 90044f5

@szuend
szuend deleted the remove-async-stack-tagging-api branch October 19, 2022 05:49
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
PR-URL: #45051
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
PR-URL: #45051
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45051
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45051
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@szuend@nodejs-github-bot@targos@aduh95