Skip to content

test: watch mode inspect restart repeatedly - #45060

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:make-wath-mode-inspect-test-more-robust
Oct 22, 2022
Merged

test: watch mode inspect restart repeatedly#45060
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:make-wath-mode-inspect-test-more-robust

Conversation

@MoLow

@MoLowMoLow commented Oct 18, 2022

Copy link
Copy Markdown
Member

Fixes: #44805

the timeout seems to occure when saving a single change of the file was not enough to trigger watch mode, so watch mode is triggerd repeatedly instead - until it succeeds to restart twice

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2022
@MoLowMoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
@Trott

Trott commented Oct 19, 2022

Copy link
Copy Markdown
Member

Typo in commit: wath -> watch

@MoLow
MoLowforce-pushed the make-wath-mode-inspect-test-more-robust branch from 1b8dbee to 04d4df4CompareOctober 19, 2022 05:07
@TrottTrott changed the title test: wath mode inspect restart repeatedlytest: watch mode inspect restart repeatedlyOct 19, 2022
@MoLow

MoLow commented Oct 20, 2022

Copy link
Copy Markdown
MemberAuthor

Cc @nodejs/testing
If someone can review this it will be great

@MoLowMoLow added the review wanted PRs that need reviews. label Oct 20, 2022
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2022
@Trott

Trott commented Oct 20, 2022

Copy link
Copy Markdown
Member

@nodejs/fs

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@MoLowMoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2022•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47371/ 💚

This was referenced Oct 21, 2022
Open
Open
@jasnelljasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 47b63f5 into nodejs:mainOct 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

Landed in 47b63f5

@MoLow
MoLow deleted the make-wath-mode-inspect-test-more-robust branch October 22, 2022 19:12
This was referenced Oct 23, 2022
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@MoLow@RafaelGSS
test: watch mode inspect restart repeatedly
9a146ba
PR-URL: #45060Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@MoLow@RafaelGSS
test: watch mode inspect restart repeatedly
2b3b291
PR-URL: #45060Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow@danielleadams
test: watch mode inspect restart repeatedly
bdf7f25
PR-URL: #45060Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@MoLow@danielleadams
test: watch mode inspect restart repeatedly
a8030b9
PR-URL: #45060Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.review wantedPRs that need reviews.testIssues and PRs related to the tests.watch-modeIssues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-watch-mode-inspect

5 participants

@MoLow@Trott@nodejs-github-bot@jasnell@benjamingr