Skip to content

doc: update mark release line lts on release guide - #45101

Merged
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
ruyadorno:update-marking-release-line-as-lts-on-release-guide
Oct 24, 2022
Merged

doc: update mark release line lts on release guide#45101
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
ruyadorno:update-marking-release-line-as-lts-on-release-guide

Conversation

@ruyadorno

@ruyadornoruyadorno commented Oct 20, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Updates the Release Guide to point to using node-core-utils for creating the commit that marks a release line as LTS.

cc @nodejs/releasers

@ruyadorno
doc: update mark release line lts on release guide
e6d1cdf
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.
Signed-off-by: Ruy Adorno <ruyadorno@google.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2022•
edited by ruyadorno
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 20, 2022
mhdawson
mhdawson approved these changes Oct 20, 2022
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RafaelGSS
RafaelGSS reviewed Oct 21, 2022
View reviewed changes
Comment threaddoc/contributing/releases.md Outdated
Comment threaddoc/contributing/releases.md Outdated
ruyadornoand others added 2 commits October 21, 2022 11:16
@ruyadorno@RafaelGSS
Update doc/contributing/releases.md
c8653ea
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@ruyadorno@RafaelGSS
Update doc/contributing/releases.md
7c0a5cb
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 21, 2022
@github-actions

github-actionsBot commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@ruyadornoruyadorno added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022
aduh95
aduh95 approved these changes Oct 22, 2022
View reviewed changes
Comment threaddoc/contributing/releases.md
@ruyadorno@aduh95
Update doc/contributing/releases.md
520e533
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 24, 2022
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 24, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1930fcd into nodejs:mainOct 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1930fcd

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@ruyadorno@RafaelGSS
doc: update mark release line lts on release guide
423307c
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.
Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@ruyadorno@RafaelGSS
doc: update mark release line lts on release guide
85cb4d7
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.
Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ruyadorno@danielleadams
doc: update mark release line lts on release guide
f390de9
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.
Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@ruyadorno@danielleadams
doc: update mark release line lts on release guide
17380a1
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.
Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@legendecaslegendecaslegendecas approved these changes
@aduh95aduh95aduh95 approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@ruyadorno@nodejs-github-bot@jasnell@lpinca@anonrig@richardlau@BethGriggs@legendecas@mhdawson@aduh95@RafaelGSS