Skip to content

[v14.x backport] tools: add more options to track flaky tests - #45126

Closed
aduh95 wants to merge 2 commits into
nodejs:v14.x-stagingfrom
aduh95:backport-v14-mesure-flakiness
Closed

[v14.x backport] tools: add more options to track flaky tests#45126
aduh95 wants to merge 2 commits into
nodejs:v14.x-stagingfrom
aduh95:backport-v14-mesure-flakiness

Conversation

@aduh95

@aduh95aduh95 commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

Backport of #43954, needed for nodejs/build#3056.

@aduh95
tools: add more options to track flaky tests
e8318a1
Refs: nodejs#43929 (comment)
PR-URL: nodejs#43954
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. v14.x labels Oct 22, 2022
@aduh95aduh95 mentioned this pull request Oct 22, 2022
Merged
richardlau
richardlau reviewed Oct 22, 2022
View reviewed changes
Comment thread.github/workflows/build-tarball.yml
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 22, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47405/

@richardlau

richardlau commented Oct 22, 2022

Copy link
Copy Markdown
Member

This will need changes so that it also works with Python 2 if it is to land in v14.x.

@richardlaurichardlau removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2022
aduh95
aduh95 commented Oct 22, 2022
View reviewed changes
Comment threadtools/test.py Outdated
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 22, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47409/

@github-actionsgithub-actionsBot mentioned this pull request Oct 23, 2022
Open
13 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47412/

@github-actionsgithub-actionsBot mentioned this pull request Oct 24, 2022
Open
13 tasks
@aduh95

aduh95 commented Oct 24, 2022

Copy link
Copy Markdown
ContributorAuthor

@nodejs/lts can this be merged to unblock nodejs/build#3056 please?

@richardlaurichardlau mentioned this pull request Oct 24, 2022
Merged
mhdawson
mhdawson approved these changes Oct 24, 2022
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Oct 25, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 26, 2022
@aduh95@danielleadams
tools: add more options to track flaky tests
a1d5209
Refs: #43929 (comment)
PR-URL: #43954
Backport-PR-URL: #45126
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@danielleadams

danielleadams commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Landed in a1d5209

@aduh95
aduh95 deleted the backport-v14-mesure-flakiness branch October 26, 2022 23:14
@github-actionsgithub-actionsBot mentioned this pull request Oct 27, 2022
Open
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.testIssues and PRs related to the tests.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@richardlau@danielleadams@mhdawson@RafaelGSS