deps: update V8 to 10.8 by targos · Pull Request #45230 · nodejs/node

targos · 2022-10-29T09:43:32Z

Stable Release:
Tue, Nov 29, 2022

nodejs-github-bot · 2022-10-29T09:43:36Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

targos · 2022-10-31T10:49:24Z

There's also a failure with test-trace-gc-flag

12:10:45 not ok 1 v8-updates/test-trace-gc-flag
12:10:45 ---
12:10:45 duration_ms: 0.348
12:10:45 severity: fail
12:10:45 exitcode: 1
12:10:45 stack: |-
12:10:45 node:assert:1027
12:10:45 throw err;
12:10:45 ^
12:10:45 12:10:45 AssertionError [ERR_ASSERTION]: The input did not match the regular expression /\bMark-sweep\b/. Input:
12:10:45 12:10:45 '[41903:0x55803f320350] 93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms (average mu = 1.000, current mu = 1.000) testing; GC in old space requested'
12:10:45 12:10:45 at /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:30:12
12:10:45 at Array.forEach (<anonymous>)
12:10:45 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:29:9)
12:10:45 at Module._compile (node:internal/modules/cjs/loader:1175:14)
12:10:45 at Module._extensions..js (node:internal/modules/cjs/loader:1229:10)
12:10:45 at Module.load (node:internal/modules/cjs/loader:1038:32)
12:10:45 at Module._load (node:internal/modules/cjs/loader:879:12)
12:10:45 at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:82:12)
12:10:45 at node:internal/main/run_main_module:23:47 {
12:10:45 generatedMessage: true,
12:10:45 code: 'ERR_ASSERTION',
12:10:45 actual: '[41903:0x55803f320350] 93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms (average mu = 1.000, current mu = 1.000) testing; GC in old space requested',
12:10:45 expected: /\bMark-sweep\b/,
12:10:45 operator: 'match'
12:10:45 }
12:10:45 12:10:45 Node.js v20.0.0-pre
12:10:45 ...

/cc @tony-go

targos · 2022-10-31T13:15:26Z

@nodejs/platform-windows

x86 build fails on Windows:

12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(344,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(59,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

StefanStojanovic · 2022-11-02T14:38:04Z

Hello, @targos. All failing asserts are manifestations of the same issue - MemoryChunkLayout::kMemoryChunkHeaderSize not being set to the correct value. I've found this commit in the v8 repo that fixes the problem. I've tried it locally and the build passes.

targos · 2022-11-02T14:50:32Z

@StefanStojanovic thanks! I'll cherry-pick that commit

nodejs-github-bot · 2022-11-05T09:14:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47713/

nodejs-github-bot · 2022-11-05T09:15:16Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4961/

nodejs-github-bot · 2022-11-05T09:19:17Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4961/

nodejs-github-bot · 2022-11-05T09:43:24Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4961/

targos · 2022-11-19T09:20:10Z

It's the first time we land a V8 PR with the CQ. I hope it won't break anything with commit messages like this one:

PR-URL: nodejs#35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> deps: patch for v8 on windows PR-URL: nodejs#40010 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> deps: patch v8 for vs2019 in std17 PR-URL: nodejs#40060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> deps: workaround debug link error on Windows PR-URL: nodejs#38807 Refs: nodejs#38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs#42375 PR-URL: nodejs#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: [heap] Fix 32bit msvc builds Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus forcing 8 bytes alignment for MemoryChunk. Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#83845} Refs: v8/v8@92a7385 PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: [base] Fix SmartOS build That platform doesn't have `malloc_usable_size`. Refs: nodejs/node-v8#239 Change-Id: I011dd8449d02b27219a32cba00132cd068069f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/main@{#84256} Refs: v8/v8@f1c888e PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: Add an `v8::ArrayBuffer::WasDetached` method to the C++ API V8's C++ API does not give a way to tell whether an ArrayBuffer has been detached from the `v8::ArrayBuffer` class. In fact, as far as can be told from the C++ API without running JS code, detached ArrayBuffers behave the same as zero-sized ArrayBuffers and there is no way to observe the difference. However, this difference can be observed in JS because constructing a TypedArray from a detached ArrayBuffer will throw. This change adds a `WasDetached` method to the `v8::ArrayBuffer` class to give embedders access to this information without having to run JS code. Bug: v8:13159 Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#83963} Refs: v8/v8@9df5ef7 PR-URL: #45474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 29, 2022

targos added dont-land-on-v14.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 29, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2022

This comment was marked as outdated.
Sign in to view

This comment was marked as resolved.
Sign in to view

This was referenced Oct 30, 2022
CI Reliability 2022-10-30 nodejs/reliability#415
Open
CI Reliability 2022-10-31 nodejs/reliability#416
Open

This was referenced Nov 1, 2022
CI Reliability 2022-11-01 nodejs/reliability#417
Open
CI Reliability 2022-11-02 nodejs/reliability#418
Open

targos force-pushed the v8-108 branch from b0f077c to 9608083Compare November 5, 2022 09:10

This was referenced Nov 6, 2022
CI Reliability 2022-11-06 nodejs/reliability#420
Open
CI Reliability 2022-11-07 nodejs/reliability#421
Open
CI Reliability 2022-11-08 nodejs/reliability#422
Open

This was referenced Nov 20, 2022
CI Reliability 2022-11-20 nodejs/reliability#434
Open
CI Reliability 2022-11-21 nodejs/reliability#435
Open

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
deps: update V8 to 10.8.168.20
a3b9967
PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
build: reset embedder string to "-node.0"
54fd8a1
PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
test: adapt test-v8-stats for V8 update
72f2df2
PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
test: fix test-trace-gc-flag
076e9ee
PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

github-actionsBot mentioned this pull request Nov 22, 2022
CI Reliability 2022-11-22 nodejs/reliability#436
Open
15 tasks

ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged

gengjiawen mentioned this pull request Feb 1, 2023
deps: update V8 to 11.1 #46445
Closed

AdamMajer mentioned this pull request Mar 13, 2023
s390x: illegal instruction in unit tests #47064
Closed

Navigation Menu

Uh oh!

Uh oh!

deps: update V8 to 10.8 - #45230

deps: update V8 to 10.8#45230
targos wants to merge 11 commits into
nodejs:mainfrom
targos:v8-108

targos commented Oct 29, 2022•
edited
Loading

Uh oh!

nodejs-github-bot commented Oct 29, 2022

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

targos commented Oct 31, 2022

Uh oh!

targos commented Oct 31, 2022•
edited
Loading

Uh oh!

StefanStojanovic commented Nov 2, 2022

Uh oh!

targos commented Nov 2, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

targos commented Nov 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

targos commented Oct 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 29, 2022

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

targos commented Oct 31, 2022

Uh oh!

targos commented Oct 31, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanStojanovic commented Nov 2, 2022

Uh oh!

targos commented Nov 2, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

nodejs-github-bot commented Nov 5, 2022

Uh oh!

targos commented Nov 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

targos commented Oct 29, 2022•
edited
Loading

targos commented Oct 31, 2022•
edited
Loading