Uh oh!
There was an error while loading. Please reload this page.
tools: update lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3 - #45237
Conversation
Fast-track has been requested by @aduh95. Please 👍 to approve. |
MoLow
left a comment
There was a problem hiding this comment.
not sure what needs to be done in cases like this where the commit message is too long
Trott
commented
Oct 30, 2022
I usually check out the branch, edit the commit message, and force-push it back to the feature branch. I'll do that now. |
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3.
d5e5fa3 to
72e4905Comparenodejs-github-bot
commented
Oct 30, 2022
Another solution would be to leave it as is and to land it manually, editing the commit message at that time. It's the same result, the only difference being that you save one CI cycle. Speaking of CI, I don't think we need to have a passing Jenkins CI for that kind of change (it's only changing the name of a class), all the CI failures look unrelated anyway. |
Trott
commented
Oct 30, 2022
I guess I'm still scarred from that one time that a change in lint-md caused CI failures in...like...was it build-without-intl or something? I forget. Some non-default CI build that we test. |
nodejs-github-bot
commented
Oct 30, 2022
nodejs-github-bot
commented
Oct 31, 2022
nodejs-github-bot
commented
Oct 31, 2022
Landed in 548f505 |
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This is an automated update of lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3.