Skip to content

Add automation for updating base64 dependency - #45300

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
facutuesca:base64-ci-update
Nov 6, 2022
Merged

Add automation for updating base64 dependency#45300
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
facutuesca:base64-ci-update

Conversation

@facutuesca

@facutuescafacutuesca commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Add a Github Action that checks for new versions of the base64 C library, and creates a PR to update it if a newer version than the one present in the repo is found.

Refs: nodejs/security-wg#828

@nodejs-github-bot

nodejs-github-bot commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 3, 2022
aduh95
aduh95 reviewed Nov 3, 2022
View reviewed changes
Comment threadtools/update-base64.sh Outdated
Comment thread.github/workflows/tools.yml Outdated
@aduh95

aduh95 commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

I tried running the script locally to update to 0.5.0, and I see only two modified files. Is it expected?

@facutuesca

facutuesca commented Nov 3, 2022

Copy link
Copy Markdown
ContributorAuthor

I tried running the script locally to update to 0.5.0, and I see only two modified files. Is it expected?

Yeah, currently the version of base64 present in Node's repo is not 0.4.0, but rather a specific commit between 0.4.0 and 0.5.0 (which was done by this PR #44032)

Looking at the commit history of base64, you can see that that commit is the last one before the version was bumped to 0.5.0:
image

So indeed updating to 0.5.0 only changes two files (one leftover empty file that is removed, and the other with the version bump)

aduh95
aduh95 approved these changes Nov 3, 2022
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may need to be disabled next time we need to pull a version between releases, but hopefully this won't be needed, and it's certainly better to have it automated in the mean time anyway

lpinca
lpinca approved these changes Nov 3, 2022
View reviewed changes
Comment thread.github/workflows/tools.yml Outdated
Comment threadtools/update-base64.sh Outdated

@lpincalpincaNov 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BASE_DIR="$(pwd)"
BASE_DIR=$(cd "$(dirname "$0")/.."&& pwd)

This should make it work from anywhere.

@facutuescafacutuescaNov 4, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@facutuesca
tools: add automation for updating base64 dependency
ca1857a
Add a Github Action that checks for new versions of the `base64` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.
Refs: nodejs/security-wg#828
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1f51713 into nodejs:mainNov 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1f51713

@facutuesca
facutuesca deleted the base64-ci-update branch November 7, 2022 10:18
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@facutuesca@RafaelGSS
tools: add automation for updating base64 dependency
eda4ae5
Add a Github Action that checks for new versions of the `base64` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.
Refs: nodejs/security-wg#828
PR-URL: #45300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 10, 2022
Merged
@lucshi

lucshi commented Nov 11, 2022•
edited
Loading

Copy link
Copy Markdown

There is a Base64 update patch in PR #45091 which is approved but not merged yet.
To make the latest Base64 works best, it needs changes in gyp files as in that PR.

@facutuesca

facutuesca commented Nov 14, 2022

Copy link
Copy Markdown
ContributorAuthor

There is a Base64 update patch in PR #45091 which is approved but not merged yet. To make the latest Base64 works best, it needs changes in gyp files as in that PR.

@lucshi This script only deals with updating the folder base64 to the latest released version, any changes needed to Node's gyp files have to be added manually on top of that.

@facutuescafacutuesca mentioned this pull request Dec 8, 2022
Closed
23 tasks
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca@danielleadams
tools: add automation for updating base64 dependency
4a4f63d
Add a Github Action that checks for new versions of the `base64` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.
Refs: nodejs/security-wg#828
PR-URL: #45300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@facutuesca@danielleadams
tools: add automation for updating base64 dependency
75a146f
Add a Github Action that checks for new versions of the `base64` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.
Refs: nodejs/security-wg#828
PR-URL: #45300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@facutuesca@nodejs-github-bot@aduh95@lucshi@Trott@lpinca