Uh oh!
There was an error while loading. Please reload this page.
tools: increase macOS cores to 3 on GitHub CI - #45340
Conversation
In efbec85, we reduced the cores to 2 based on GitHub documentation. The documentation now says that there are 3 cores. Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
nodejs-github-bot
commented
Nov 6, 2022
Review requested:
|
| run: make build-ci -j3 V=1 CONFIG_FLAGS="--error-on-warn" | ||
| - name: Test | ||
| run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9" | ||
| run: make run-ci -j3 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9" |
There was a problem hiding this comment.
@Trott Can we get the core count using bash, and remove the need to update this workflow in the future? Something like getconf _NPROCESSORS_ONLN
There was a problem hiding this comment.
If we're sure it returns the right number on virtual machines (instead of returning the number available to the physical host that the VM is running on), yeah, that would be great. I'm going to let this run as-is so we can confirm that -j3 is faster than -j2. I'll leave a comment about that on main.
Trott
commented
Nov 6, 2022
The last successful GitHub Action (at the time of this writing) for building/testing on macOS took 1h 50m 36s for the build step, 33m 0s for the test step, and 2h 24m 49s overall. https://github.com/nodejs/node/actions/runs/3404078997/jobs/5661053610 Hopefully this will improve at least a tiny bit on those times... https://github.com/nodejs/node/actions/runs/3405116815/jobs/5662849595 |
This cuts the build time by about 28%, around a half hour. Let's land it! Build time went from 1h 50m 36s to 1h 19m 11s. 🚀 Test time went from 33m to 30m. Tests are parallelized by Total time went form 2h 24m 49s to 1h 50m 33s. 🚀 |
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
commented
Nov 6, 2022
Landed in f9fab41 |
In efbec85, we reduced the cores to 2 based on GitHub documentation. The documentation now says that there are 3 cores. Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources PR-URL: #45340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #45340 (comment) PR-URL: #45350 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: #45340 (comment) PR-URL: #45350 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
In efbec85, we reduced the cores to 2 based on GitHub documentation. The documentation now says that there are 3 cores. Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources PR-URL: #45340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #45340 (comment) PR-URL: #45350 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
In efbec85, we reduced the cores to 2 based on GitHub documentation. The documentation now says that there are 3 cores. Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources PR-URL: #45340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #45340 (comment) PR-URL: #45350 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
In efbec85, we reduced the cores to 2 based on GitHub documentation. The documentation now says that there are 3 cores.
Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources