Uh oh!
There was an error while loading. Please reload this page.
doc: add arm64 to os.machine() - #45374
Merged
Merged
Conversation
anonrig
approved these changes
Nov 8, 2022
Trott
approved these changes
Nov 8, 2022
Trott
left a comment
Member
There was a problem hiding this comment.
Can you amend the commit message to be doc: add arm64 to os.machine() and force push to this branch?
arm64 to os.machine()cjihrig
approved these changes
Nov 8, 2022
lpinca
approved these changes
Nov 8, 2022
jasnell
approved these changes
Nov 16, 2022
nodejs-github-bot
commented
Nov 17, 2022
Collaborator
Landed in 490c3d6 |
ruyadorno pushed a commit
that referenced
this pull request
Nov 21, 2022
PR-URL: #45374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
danielleadams pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arm64is a much more common machine name thans390xso I think it deserves a spot on in the sunlight.