Uh oh!
There was an error while loading. Please reload this page.
doc: typography mistake - #45398
Conversation
nodejs-github-bot
commented
Nov 10, 2022
Review requested:
|
Trott
left a comment
There was a problem hiding this comment.
This is not a spelling mistake although it is awkward typography.
kovsu
commented
Nov 10, 2022
I don't know how to express it 😀. And thanks for immediately correcting my mistake. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Do we have an official way of styling this? For example, (outside of nodejs docs) I write
require()edimportedimport()ed
I've been looking for guidance in the Microsoft Style Guide (which we try to follow) but haven't found any. My personal opinion, though, is that we should avoid using function names as verbs.
For these reasons (and probably a few other reasons I haven't thought of), I think it's best to use a separate verb and let the function name be what it actually is, which is a noun. It might be good to standardize for some specific cases, though. This PR uses "included via |
JakobJingleheimer
commented
Nov 11, 2022
I think it would be good to establish some kind of policy, otherwise we'll end up with a bunch of these issues/PRs. Colloquial English turns pretty much any word into a verb/past-participle by just adding "ed" to the end, so I think it's acceptable here. RE confusion about to what it's referring, that's why I include the parentheses: But I'm also totally fine with "included via |
nodejs-github-bot
commented
Nov 13, 2022
Landed in c4d75ea |
PR-URL: #45398 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: #45398 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: #45398 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>

No description provided.