Uh oh!
There was an error while loading. Please reload this page.
[v19.x] lib: fix eslint early return - #45409
Closed
RafaelGSS wants to merge 1 commit into
Closed
Conversation
The nodejs#45243 upgraded eslint and apparently, when you specific a `@returns` early returns aren't considered valid. This PR fixes this lint issue.
RafaelGSS
commented
Nov 10, 2022
MemberAuthor
I'm requesting |
Contributor
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
RafaelGSS
commented
Nov 10, 2022
MemberAuthor
Do I need CI for this PR? |
panva
approved these changes
Nov 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Nov 10, 2022
ruyadorno
approved these changes
Nov 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
19 tasks
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Nov 11, 2022
Collaborator
BethGriggs
approved these changes
Nov 11, 2022
RafaelGSS
commented
Nov 11, 2022
MemberAuthor
The Windows issue is a known problem at the moment, and considering the fact we need this patch for #45269 and a new CI will run for the proposal, I'll land it anyway. |
RafaelGSS added a commit
that referenced
this pull request
Nov 11, 2022
The #45243 upgraded eslint and apparently, when you specific a `@returns` early returns aren't considered valid. This PR fixes this lint issue. PR-URL: #45409 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
RafaelGSS
commented
Nov 11, 2022
MemberAuthor
Landed in e2181e0 |
RafaelGSS
commented
Nov 11, 2022
MemberAuthor
Ref: nodejs/build#3075 |
Merged
This was referenced Nov 12, 2022
This was referenced Nov 14, 2022
danielleadams pushed a commit
that referenced
this pull request
Dec 30, 2022
The #45243 upgraded eslint and apparently, when you specific a `@returns` early returns aren't considered valid. This PR fixes this lint issue. PR-URL: #45409 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 3, 2023
The #45243 upgraded eslint and apparently, when you specific a `@returns` early returns aren't considered valid. This PR fixes this lint issue. PR-URL: #45409 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #45243 updated eslint, and apparently when you specify a
@returnsearly returns aren't considered valid. This PR fixes this lint issue.In the
mainbranch it's not failing because #41276 fixes it indirectly.FYI @Trott
cc: @nodejs/releasers this probably needs to be backported/cherry-picked to all active release lines.