Skip to content

src: don't run tasks on isolate termination - #45444

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
santigimeno:santi/fix_45419
Nov 17, 2022
Merged

src: don't run tasks on isolate termination#45444
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
santigimeno:santi/fix_45419

Conversation

@santigimeno

@santigimenosantigimeno commented Nov 13, 2022

Copy link
Copy Markdown
Member

Fixes: #45419

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 13, 2022
@Trott

Trott commented Nov 13, 2022

Copy link
Copy Markdown
Member

Is it reasonable to add a test for this?

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47910/

This was referenced Nov 14, 2022
Open
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Nov 17, 2022
Open
13 tasks
@santigimeno

santigimeno commented Nov 17, 2022

Copy link
Copy Markdown
MemberAuthor

Is it reasonable to add a test for this?

I'd love to, but it's not really straightforward. If someone wants to take the undici test and strip it down to a basic reproducer, it'd be great.

@santigimenosantigimeno added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47980/

@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47994/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@nodejs-github-bot
nodejs-github-bot merged commit b18ec04 into nodejs:mainNov 17, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

Landed in b18ec04

This was referenced Nov 18, 2022
Open
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@santigimeno@ruyadorno
src: don't run tasks on isolate termination
5e5bf0c
Fixes: #45419
PR-URL: #45444
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 22, 2022
Open
15 tasks
@ruyadornoruyadorno mentioned this pull request Nov 24, 2022
Merged
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@santigimeno@danielleadams
src: don't run tasks on isolate termination
e343511
Fixes: #45419
PR-URL: #45444
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@santigimeno@danielleadams
src: don't run tasks on isolate termination
2c6a4fd
Fixes: #45419
PR-URL: #45444
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash when running undici's wpt runner in node v19

6 participants

@santigimeno@Trott@nodejs-github-bot@bnoordhuis@jasnell@lpinca