Skip to content

lib: improve AbortController creation duration - #45525

Closed
anonrig wants to merge 2 commits into
nodejs:mainfrom
anonrig:stream/abort-controller
Closed

lib: improve AbortController creation duration#45525
anonrig wants to merge 2 commits into
nodejs:mainfrom
anonrig:stream/abort-controller

Conversation

@anonrig

@anonriganonrig commented Nov 19, 2022

Copy link
Copy Markdown
Member
  1. Remove createAbortSignal() call unless signal getter is called.
  2. Improve kMakeTransferable abort signal creation.

@anonriganonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Nov 19, 2022
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 19, 2022
@anonriganonrig changed the title Stream/abort controllerlib: improve AbortController creation durationNov 19, 2022
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48026/

mcollina
mcollina approved these changes Nov 19, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Are we gaining any perf?

@anonrig

anonrig commented Nov 19, 2022

Copy link
Copy Markdown
MemberAuthor

Are we gaining any perf?

For certain paths, 100% sure. But I am not sure with benchmark is more appropriate for this change. Any recommendations @mcollina?

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2022
aduh95
aduh95 reviewed Nov 19, 2022
View reviewed changes
Comment threadlib/internal/abort_controller.js Outdated
Comment threadlib/internal/abort_controller.js Outdated
@aduh95aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2022
@anonrig
anonrigforce-pushed the stream/abort-controller branch 2 times, most recently from bef645b to c2b464bCompareNovember 19, 2022 21:32
aduh95
aduh95 reviewed Nov 19, 2022
View reviewed changes
Comment threadlib/internal/abort_controller.js Outdated
@anonrig
anonrigforce-pushed the stream/abort-controller branch from c2b464b to 34489feCompareNovember 19, 2022 22:17
@anonrig
anonrig requested a review from aduh95November 19, 2022 22:22
@anonrig

anonrig commented Nov 19, 2022

Copy link
Copy Markdown
MemberAuthor

@aduh95@mcollina Can you review it again, please?

@aduh95

aduh95 commented Nov 19, 2022

Copy link
Copy Markdown
Contributor

Don't hesitate to use fixup commits (i.e. git commit --fixup) to avoid force-pushing, as force pushing doesn't make a great reviewing experience (and our tooling can perfectly handle fixup commits).

@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 19, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48029/

@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48032/

@anonriganonrig added the performance Issues and PRs related to the performance of Node.js. label Nov 20, 2022
mcollina
mcollina approved these changes Nov 20, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2022
@github-actionsgithub-actionsBot mentioned this pull request Nov 21, 2022
Open
15 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in b4666c3...367ac71

nodejs-github-bot pushed a commit that referenced this pull request Nov 21, 2022
@anonrig@nodejs-github-bot
lib: improve AbortController creation duration
5fe7003
PR-URL: #45525
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 21, 2022
@anonrig@nodejs-github-bot
lib: improve transferable abort controller exec
367ac71
PR-URL: #45525
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Nov 22, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@anonrig@ruyadorno
lib: improve AbortController creation duration
5745bcb
PR-URL: #45525
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@anonrig@ruyadorno
lib: improve transferable abort controller exec
4c9159a
PR-URL: #45525
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadornoruyadorno mentioned this pull request Nov 24, 2022
Merged
@danielleadams

danielleadams commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Hi @anonrig - should this PR land in v18.x? If so, it will need a backport PR. Thank you.

@anonriganonrig mentioned this pull request Jan 3, 2023
Closed
anonrig added a commit to anonrig/node that referenced this pull request Jan 3, 2023
@anonrig
lib: improve AbortController creation duration
29fa2da
PR-URL: nodejs#45525
Backport-PR-URL: nodejs#46078
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jan 3, 2023
@anonrig
lib: improve transferable abort controller exec
12bf9b8
PR-URL: nodejs#45525
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@aduh95@danielleadams@mcollina