deps: update nghttp2 to 1.51.0 by anonrig · Pull Request #45537 · nodejs/node

I'd prefer someone with more familiarity with this review it, but if no one does so, I'll do my best, but it won't be too much better than a rubber-stamp. Feel free to ping me Monday if this doesn't have any reviews by then.

RafaelGSS · 2022-11-23T21:23:51Z

I'll try to review it pretty soon.

RafaelGSS

LGTM. By the way, would be great to have a contributing/maintaining-nghttp2 so we don't need to be meticulous on the review.

mcollina

lgtm

nodejs-github-bot · 2022-11-25T11:07:41Z

Landed in 1a83ad6

PR-URL: #45537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nodejs/node#45537

* chore: bump node in DEPS to v18.13.0 * child_process: validate arguments for null bytes nodejs/node#44782 * bootstrap: merge main thread and worker thread initializations nodejs/node#44869 * module: ensure relative requires work from deleted directories nodejs/node#42384 * src: add support for externally shared js builtins nodejs/node#44000 * lib: disambiguate `native module` to `binding` nodejs/node#45673 * test: convert test-debugger-pid to async/await nodejs/node#45179 * deps: upgrade to libuv 1.44.2 nodejs/node#42340 * src: fix cppgc incompatibility in v8 nodejs/node#43521 * src: use qualified `std::move` call in node_http2 nodejs/node#45555 * build: fix env.h for cpp20 nodejs/node#45516 * test: remove experimental-wasm-threads flag nodejs/node#45074 * src: iwyu in cleanup_queue.cc nodejs/node#44983 * src: add missing include for `std::all_of` nodejs/node#45541 * deps: update ICU to 72.1 nodejs/node#45068 * chore: fixup patch indices * chore: remove errant semicolons - nodejs/node#44179 - nodejs/node#44193 * src: add support for externally shared js builtins nodejs/node#44376 * chore: add missing GN filenames * deps: update nghttp2 to 1.51.0 nodejs/node#45537 * chore: disable more Node.js snapshot tests The Snapshot feature is currently disabled * chore: disable ICU timezone tests Node.js uses a different version of ICU than Electron so they will often be out of sync. * chore: disable threadpool event tracing test Event tracing is not enabled in embedded Node.js * chore: fixup patch indices * chore: comments from review Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

deps: update nghttp2 to 1.51.0
2d8ce98

nodejs-github-bot added build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Nov 20, 2022

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2022

github-actionsBot mentioned this pull request Nov 21, 2022
CI Reliability 2022-11-21 nodejs/reliability#435
Open
15 tasks

anonrig requested a review from targos November 21, 2022 15:12

This was referenced Nov 22, 2022
CI Reliability 2022-11-22 nodejs/reliability#436
Open
CI Reliability 2022-11-23 nodejs/reliability#437
Open

github-actionsBot mentioned this pull request Nov 24, 2022
CI Reliability 2022-11-24 nodejs/reliability#438
Open
16 tasks

RafaelGSS approved these changes Nov 25, 2022
View reviewed changes

mcollina approved these changes Nov 25, 2022
View reviewed changes

mcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 25, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2022

nodejs-github-bot merged commit 1a83ad6 into nodejs:mainNov 25, 2022

bricss mentioned this pull request Nov 28, 2022
v19.2.0 proposal #45615
Merged

targos pushed a commit that referenced this pull request Dec 12, 2022
deps: update nghttp2 to 1.51.0
60c9ac5
PR-URL: #45537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged

danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged

danielleadams pushed a commit that referenced this pull request Dec 30, 2022
deps: update nghttp2 to 1.51.0
ce1b4e9
PR-URL: #45537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 3, 2023
deps: update nghttp2 to 1.51.0
7b6d2a8
PR-URL: #45537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 5, 2023
deps: update nghttp2 to 1.51.0
767fac9
PR-URL: #45537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request Jan 9, 2023
deps: update nghttp2 to 1.51.0
1a2c3a3
nodejs/node#45537

Uh oh!

Uh oh!

Conversation

anonrig commented Nov 20, 2022

Uh oh!

nodejs-github-bot commented Nov 20, 2022

Uh oh!

nodejs-github-bot commented Nov 20, 2022

Uh oh!

targos commented Nov 20, 2022

Uh oh!

nodejs-github-bot commented Nov 20, 2022

Uh oh!

anonrig commented Nov 21, 2022

Uh oh!

nodejs-github-bot commented Nov 21, 2022

Uh oh!

anonrig commented Nov 23, 2022

Uh oh!

anonrig commented Nov 23, 2022

Uh oh!

Trott commented Nov 23, 2022

Uh oh!

RafaelGSS commented Nov 23, 2022

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants