Skip to content

draft: implement bufferToString - #45562

Closed
kiliczsh wants to merge 9 commits into
nodejs:mainfrom
kiliczsh:bufferToString
Closed

draft: implement bufferToString#45562
kiliczsh wants to merge 9 commits into
nodejs:mainfrom
kiliczsh:bufferToString

Conversation

@kiliczsh

@kiliczshkiliczsh commented Nov 21, 2022

Copy link
Copy Markdown

Trying to implement suggested performance improvement in nodejs/performance#16.

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 21, 2022
@kiliczshkiliczsh changed the title src: implement bufferToStringdraft: implement bufferToStringNov 21, 2022
anonrig
anonrig reviewed Nov 21, 2022
View reviewed changes
Comment threadsrc/node_buffer.cc Outdated
Comment threadsrc/node_buffer.cc Outdated
Comment threadsrc/node_buffer.cc Outdated
Comment threadsrc/node_buffer.cc Outdated
Comment threadsrc/node_buffer.cc Outdated
@mscdex

mscdex commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Did you see the linked comment in the code comment for this function? I think we shouldn't be spending effort on optimizing APIs that exist solely for compatibility with older code.

@anonrig

anonrig commented Nov 21, 2022

Copy link
Copy Markdown
Member

Did you see the linked comment in the code comment for this function? I think we shouldn't be spending effort on optimizing APIs that exist solely for compatibility with older code.

@mscdex This change also applies to several other places like _http_client.js and random.js (Referencing nodejs/performance#16)

@mscdex

mscdex commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

This change also applies to several other places like _http_client.js and random.js

That's fine, I'm referring specifically to btoa() (and atob() for that matter), which is what this PR is currently changing.

anonrig
anonrig reviewed Nov 21, 2022
View reviewed changes
Comment threadsrc/node_buffer.cc Outdated
@kiliczsh

kiliczsh commented Jan 16, 2023

Copy link
Copy Markdown
Author

It is not applicable anymore due to nodejs/performance#16

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonrigAwaiting requested review from anonrig

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kiliczsh@mscdex@anonrig@nodejs-github-bot