Uh oh!
There was an error while loading. Please reload this page.
crypto: refactor ArrayBuffer to bigint conversion utils - #45567
Merged
Conversation
nodejs-github-bot
commented
Nov 21, 2022
Collaborator
Review requested:
|
ContributorAuthor
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1229/ Results |
aduh95
commented
Nov 22, 2022
ContributorAuthor
The benchmark results are not very interesting – and that makes sense, because this PR doesn't change any perf sensitive path AFAICT. The upside is that it improves the resilience against prototype pollution, so let's land this? |
aduh95
marked this pull request as ready for review
November 22, 2022 11:12
anonrig
approved these changes
Nov 22, 2022
aduh95force-pushed
the
crypto-bingint-arraybuffer
branch
from
November 23, 2022 12:24
74c29c9 to
3e0b647Comparenodejs-github-bot
commented
Nov 23, 2022
Collaborator
anonrig
commented
Nov 27, 2022
Member
@aduh95 Can you rebase from main? I think Asan build is failing due to Ubuntu version update. |
nodejs-github-bot
commented
Nov 27, 2022
Collaborator
jasnell
approved these changes
Nov 27, 2022
anonrig
approved these changes
Nov 27, 2022
nodejs-github-bot
commented
Nov 27, 2022
Collaborator
Landed in e7f172c |
targos pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45567 Refs: nodejs/performance#16 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45567 Refs: nodejs/performance#16 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45567 Refs: nodejs/performance#16 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45567 Refs: nodejs/performance#16 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/performance#16