repl: do not define wasi on global with no flag

[cola119]

Fixes#45560

In the REPL, prepareMainThreadExecution that updates the canBeRequiredByUsers flag of wasi module according to the flag is called after the internal/process/esm_loader.js load that creates builtinModules depending on the module.canBeRequiredByUsers flag. In this case, wasi.canBeRequiredByUsers is always true so wasi module always can be required by users even if the flag is not set.

node/lib/internal/modules/cjs/loader.js

Lines 217 to 223 in 2a7635f

	constbuiltinModules=[];
	for(const{0: id,1: mod}ofBuiltinModule.map){
	if(mod.canBeRequiredByUsers&&
	BuiltinModule.canBeRequiredWithoutScheme(id)){
	ArrayPrototypePush(builtinModules,id);
	}
	}

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48129/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48141/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/45595
✔ Done loading data for nodejs/node/pull/45595
----------------------------------- PR info ------------------------------------
Title repl: do not define `wasi` on global with no flag (#45595)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch cola119:fix-45560 -> nodejs:main
Labels repl, author ready, needs-ci
Commits 1
- repl: do not define `wasi` on global with no flag
Committers 1
- cola119 PR-URL: https://github.com/nodejs/node/pull/45595
Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45595
Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Wed, 23 Nov 2022 08:48:35 GMT
✔ Approvals: 4
✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1191699283
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1191760663
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1192375682
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45595#pullrequestreview-1192246419
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-11-23T22:44:37Z: https://ci.nodejs.org/job/node-test-pull-request/48141/
⚠ Commits were pushed after the last Full PR CI run:
⚠ - repl: do not define `wasi` on global with no flag
- Querying data for job/node-test-pull-request/48141/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3546553264

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48178/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48182/

[nodejs-github-bot]

Landed in 5a8895c