Skip to content

buffer: make decodeUTF8 params loose - #45610

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:buffer/improve
Nov 27, 2022
Merged

buffer: make decodeUTF8 params loose#45610
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:buffer/improve

Conversation

@anonrig

@anonriganonrig commented Nov 24, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This pull request removes the IsBoolean check for the second parameter of decodeUTF8 in order to make the parameter optional.

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 24, 2022
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 24, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48161/

@github-actionsgithub-actionsBot mentioned this pull request Nov 25, 2022
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48187/

@github-actionsgithub-actionsBot mentioned this pull request Nov 26, 2022
Open
21 tasks
@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48199/

@github-actionsgithub-actionsBot mentioned this pull request Nov 27, 2022
Open
21 tasks
@anonrig

anonrig commented Nov 27, 2022

Copy link
Copy Markdown
MemberAuthor

CC @nodejs/cpp-reviewers

RaisinTen
RaisinTen reviewed Nov 27, 2022
View reviewed changes
Comment threadsrc/node_buffer.cc
@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 60810f0 into nodejs:mainNov 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2022

Copy link
Copy Markdown
Collaborator

Landed in 60810f0

This was referenced Nov 28, 2022
Open
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Dec 1, 2022
Open
10 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
@anonrig@targos
buffer: make decodeUTF8 params loose
1784768
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Dec 12, 2022
Merged
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig@danielleadams
buffer: make decodeUTF8 params loose
4219dd5
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig@danielleadams
buffer: make decodeUTF8 params loose
bfcf4f0
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@anonrig@danielleadams
buffer: make decodeUTF8 params loose
7aae1ff
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anonrig@nodejs-github-bot@addaleax@RaisinTen