Uh oh!
There was an error while loading. Please reload this page.
stream: use structuredClone instead of v8 - #45611
Merged
Merged
Conversation
ErickWendel
approved these changes
Nov 24, 2022
nodejs-github-bot
commented
Nov 24, 2022
Collaborator
aduh95
reviewed
Nov 24, 2022
Uh oh!
There was an error while loading. Please reload this page.
aduh95
approved these changes
Nov 24, 2022
nodejs-github-bot
commented
Nov 24, 2022
Collaborator
lpinca
approved these changes
Nov 24, 2022
tniessen
commented
Nov 25, 2022
Member
It would be cool not to have empty commit messages and empty PR descriptions. What is being done or how it is being done is often less relevant than the reasoning behind it. |
Uh oh!
There was an error while loading. Please reload this page.
anonrig
commented
Nov 25, 2022
MemberAuthor
Thanks for the feedback. I'll add descriptions from now on. I've also updated the description for this pull request. |
nodejs-github-bot
commented
Nov 26, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45611 ✔ Done loading data for nodejs/node/pull/45611 ----------------------------------- PR info ------------------------------------ Title stream: use structuredClone instead of v8 (#45611) Author Yagiz Nizipli (@anonrig) Branch anonrig:stream/structured-clone -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x, web streams Commits 3 - stream: use structuredClone instead of v8 - fixup! stream: use structuredClone instead of v8 - fixup! stream: use structuredClone instead of v8 Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/45611 Reviewed-By: Erick Wendel Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45611 Reviewed-By: Erick Wendel Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 24 Nov 2022 16:56:34 GMT ✔ Approvals: 3 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/45611#pullrequestreview-1193461926 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45611#pullrequestreview-1193532434 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45611#pullrequestreview-1193580550 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-24T18:52:43Z: https://ci.nodejs.org/job/node-test-pull-request/48167/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - fixup! stream: use structuredClone instead of v8 - Querying data for job/node-test-pull-request/48167/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3554598277 |
nodejs-github-bot
commented
Nov 26, 2022
Collaborator
nodejs-github-bot
commented
Nov 27, 2022
Collaborator
Landed in dda7a21 |
targos pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45611 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45611 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45611 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45611 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces
deserialize(serialize(value))withstructuredClone(value)due to performance.