Skip to content

doc: fix actual result of example is different in stream - #45619

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:1125_result_different_stream
Nov 29, 2022
Merged

doc: fix actual result of example is different in stream#45619
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:1125_result_different_stream

Conversation

@deokjinkim

Copy link
Copy Markdown
Contributor

Error message of JSON.parse may be changed with current node version.
For reference, actual result is same with previous node version(v16.18.1).

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 25, 2022
@deokjinkim
deokjinkimforce-pushed the 1125_result_different_stream branch from 27aec34 to aa3d10eCompareNovember 25, 2022 04:57
Error message of JSON.parse may be changed with current node version.
For reference, actual result is same with previous node
version(v16.18.1).
@deokjinkim
deokjinkimforce-pushed the 1125_result_different_stream branch from aa3d10e to 566c5eeCompareNovember 29, 2022 03:32
@deokjinkimdeokjinkim changed the title doc: actual result is different from specified one in streamdoc: fix actual result of example is different in streamNov 29, 2022
@daeyeondaeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2022
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45619
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
at consumeBody (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Response.text (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
at async Request.json (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
at async Request.query (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
at async Request.queryAll (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
at async Request.gql (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
at async PRData.getComments (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
at async Promise.all (index 2)
at async Promise.all (index 1) {
type: 'system',
errno: 'ERR_STREAM_PREMATURE_CLOSE',
code: 'ERR_STREAM_PREMATURE_CLOSE',
erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/3573065574

@daeyeondaeyeon added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 29, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 838c97c into nodejs:mainNov 29, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 838c97c

targos pushed a commit that referenced this pull request Dec 12, 2022
Error message of JSON.parse may be changed with current node version.
For reference, actual result is same with previous node
version(v16.18.1).
PR-URL: #45619
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@targostargos mentioned this pull request Dec 12, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Error message of JSON.parse may be changed with current node version.
For reference, actual result is same with previous node
version(v16.18.1).
PR-URL: #45619
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Error message of JSON.parse may be changed with current node version.
For reference, actual result is same with previous node
version(v16.18.1).
PR-URL: #45619
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
Error message of JSON.parse may be changed with current node version.
For reference, actual result is same with previous node
version(v16.18.1).
PR-URL: #45619
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@deokjinkim@nodejs-github-bot@daeyeon@cola119