Uh oh!
There was an error while loading. Please reload this page.
doc: fix actual result of example is different in events - #45656
Conversation
bnb
commented
Nov 28, 2022
Just ran with the below code example (separately, we should probably update this specific code example to actually be runnable with the below code) and got the updated output. constEventEmitter=require('node:events');classMyEmitterextendsEventEmitter{};constmyEmitter=newMyEmitter();myEmitter.on('event',function(a,b){console.log(a,b,this,this===myEmitter);});myEmitter.emit('event','a','b'); |
Nit: the commit message title needs to start with an imperative verb to meet the guideline below. This isn't a blocker since it could be fixed by someone when landing the PR. However, it can be fixed also by a force push. node/doc/contributing/pull-requests.md Lines 168 to 171 in a1c62cf |
Change of events internal may be not reflected yet.
1ed643b to
56f9768Comparedeokjinkim
commented
Nov 29, 2022
@daeyeon Thank you for kind explanation and remind. Updated commit message title starting with an imperative verb. |
nodejs-github-bot
commented
Dec 6, 2022
Landed in ab064d1 |
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet. PR-URL: #45656 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Change of events internal may be not reflected yet.
In document, result of example is like below.
But actual result of example with current node is like below.