Skip to content

doc: fix actual result of example is different in events - #45656

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:221129_update_result_events
Dec 6, 2022
Merged

doc: fix actual result of example is different in events#45656
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:221129_update_result_events

Conversation

@deokjinkim

@deokjinkimdeokjinkim commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Change of events internal may be not reflected yet.

In document, result of example is like below.

a b MyEmitter {
domain: null,
_events: { event: [Function] },
_eventsCount: 1,
_maxListeners: undefined } true

But actual result of example with current node is like below.

a b MyEmitter {
_events: [Object: null prototype] { event: [Function (anonymous)] },
_eventsCount: 1,
_maxListeners: undefined,
[Symbol(kCapture)]: false
} true

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Nov 28, 2022
@bnb

bnb commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Just ran with the below code example (separately, we should probably update this specific code example to actually be runnable with the below code) and got the updated output.

constEventEmitter=require('node:events');classMyEmitterextendsEventEmitter{};constmyEmitter=newMyEmitter();myEmitter.on('event',function(a,b){console.log(a,b,this,this===myEmitter);});myEmitter.emit('event','a','b');

bnb
bnb approved these changes Nov 28, 2022
@daeyeon

daeyeon commented Nov 29, 2022

Copy link
Copy Markdown
Member

Nit: the commit message title needs to start with an imperative verb to meet the guideline below. This isn't a blocker since it could be fixed by someone when landing the PR. However, it can be fixed also by a force push.

* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.

Change of events internal may be not reflected yet.
@deokjinkim
deokjinkimforce-pushed the 221129_update_result_events branch from 1ed643b to 56f9768CompareNovember 29, 2022 03:28
@deokjinkimdeokjinkim changed the title doc: actual result is different from specified one in eventsdoc: fix actual result of example is different in eventsNov 29, 2022
@deokjinkim

Copy link
Copy Markdown
ContributorAuthor

Nit: the commit message title needs to start with an imperative verb to meet the guideline below. This isn't a blocker since it could be fixed by someone when landing the PR. However, it can be fixed also by a force push.

* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.

@daeyeon Thank you for kind explanation and remind. Updated commit message title starting with an imperative verb.

@daeyeondaeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit ab064d1 into nodejs:mainDec 6, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in ab064d1

targos pushed a commit that referenced this pull request Dec 12, 2022
Change of events internal may be not reflected yet.
PR-URL: #45656
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@targostargos mentioned this pull request Dec 12, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Change of events internal may be not reflected yet.
PR-URL: #45656
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Change of events internal may be not reflected yet.
PR-URL: #45656
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
Change of events internal may be not reflected yet.
PR-URL: #45656
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.eventsIssues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@deokjinkim@bnb@daeyeon@nodejs-github-bot