Skip to content

test_runner: add SuiteContext class - #45687

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debadree25:fix/add-suitecontext-as-class
Dec 2, 2022
Merged

test_runner: add SuiteContext class#45687
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debadree25:fix/add-suitecontext-as-class

Conversation

@debadree25

@debadree25debadree25 commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

added SuiteContext class to replace object literal

Fixes: #45641
Refs: #45641 (comment)

@debadree25
lib: added SuiteContext class
b23c449
added SuiteContext class to replace object literal
Fixes: nodejs#45641
Refs: nodejs#45641 (comment)
@nodejs-github-botnodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 30, 2022
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48244/

@aduh95aduh95 changed the title lib: added SuiteContext classtest_runner: add SuiteContext classNov 30, 2022
aduh95
aduh95 reviewed Nov 30, 2022
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why, though?

@debadree25

debadree25 commented Nov 30, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Why, though?

To bring consistency with the docs, the docs mention the existence of SuiteContext class and it being the first argument passed to the functions but the actual class didn't exist and the arg list was empty, hence simply added the class here

@aduh95

aduh95 commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Wouldn't fixing the docs be a more reasonable approach? To be clear, I'm not blocking this PR, but I'm skeptical that having a class is what makes the most sense here.

@debadree25

debadree25 commented Nov 30, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Wouldn't fixing the docs be a more reasonable approach? To be clear, I'm not blocking this PR, but I'm skeptical that having a class is what makes the most sense here.

I guess the only reason I can give is that it was faster to make the change in the code than having to remove all refs in the doc as refed #45641 (comment) here too 😅😅

@debadree25

debadree25 commented Nov 30, 2022

Copy link
Copy Markdown
ContributorAuthor

would be happy to go the doc approach too if you think that would be best practice!

cjihrig
cjihrig approved these changes Nov 30, 2022
View reviewed changes

@cjihrigcjihrig left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 30, 2022
@tniessen

tniessen commented Dec 1, 2022

Copy link
Copy Markdown
Member

I think @aduh95's point is valid. Is this class necessary or useful?

@cjihrig

cjihrig commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

I think it's useful for matching the other context objects and the existing documentation.

@MoLow

MoLow commented Dec 1, 2022

Copy link
Copy Markdown
Member

FWIW I do think its better to change the code than the documentation, since this name dose help understanding the responsibility of this object

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8541b3a into nodejs:mainDec 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8541b3a

targos pushed a commit that referenced this pull request Dec 12, 2022
@debadree25@targos
lib: added SuiteContext class
99410ef
added SuiteContext class to replace object literal
Fixes: #45641
Refs: #45641 (comment)
PR-URL: #45687
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Dec 12, 2022
Merged
@Semigradsky

Semigradsky commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Will this be merged to 18.x branch?

@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@debadree25@danielleadams
lib: added SuiteContext class
8d8de8d
added SuiteContext class to replace object literal
Fixes: #45641
Refs: #45641 (comment)
PR-URL: #45687
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@debadree25@danielleadams
lib: added SuiteContext class
55f800b
added SuiteContext class to replace object literal
Fixes: #45641
Refs: #45641 (comment)
PR-URL: #45687
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@debadree25@danielleadams
lib: added SuiteContext class
bf6fbe2
added SuiteContext class to replace object literal
Fixes: #45641
Refs: #45641 (comment)
PR-URL: #45687
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@cjihrigcjihrigcjihrig approved these changes
@MoLowMoLowMoLow approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[node:test] Incorrect SuiteContext description

7 participants

@debadree25@nodejs-github-bot@aduh95@tniessen@cjihrig@MoLow@Semigradsky