Skip to content

meta: update AUTHORS info for nstepien - #45692

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nstepien:patch-1
Nov 30, 2022
Merged

meta: update AUTHORS info for nstepien#45692
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nstepien:patch-1

Conversation

@nstepien

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 30, 2022
@nstepiennstepien changed the title Update AUTHORS to use my namemeta: Update AUTHORS to use my nameNov 30, 2022
@aduh95aduh95 changed the title meta: Update AUTHORS to use my namemeta: update AUTHORS info for nstepienNov 30, 2022
@aduh95

Copy link
Copy Markdown
Contributor

Can you add an entry in the .mailmap file, and then run tools/update-authors.mjs script? As is, this change would be overwritten the next time we run the script.
Optionally if you could amend the commit message so it complies with our guidelines (e.g. to meta: update AUTHORS info for nstepien) and force push, that'd be great – otherwise it can be done by whoever is landing the PR.

@nstepien

Copy link
Copy Markdown
ContributorAuthor

@aduh95 Done, thank you for your guidance.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 30, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 30, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2589fb1 into nodejs:mainNov 30, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 2589fb1

@nstepien
nstepien deleted the patch-1 branch November 30, 2022 22:36
targos pushed a commit that referenced this pull request Dec 12, 2022
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Dec 12, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nstepien@aduh95@nodejs-github-bot@Trott@lpinca