Skip to content

src: make structuredClone work for process.env - #45698

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
bnoordhuis:fix45380
Dec 11, 2022
Merged

src: make structuredClone work for process.env#45698
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
bnoordhuis:fix45380

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented Dec 1, 2022

Copy link
Copy Markdown
Member

Fixes: #45380

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 1, 2022
@bnoordhuisbnoordhuis mentioned this pull request Dec 1, 2022
Closed
anonrig
anonrig reviewed Dec 1, 2022
View reviewed changes
Comment threadsrc/node_env_var.cc Outdated
addaleax
addaleax reviewed Dec 2, 2022
View reviewed changes
Comment threadsrc/node_env_var.cc Outdated
Comment threadsrc/node_messaging.cc Outdated
Comment threadsrc/node_messaging.cc Outdated
@bnoordhuis

bnoordhuis commented Dec 7, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks for the review, Anna. PTAL if you have a moment.

@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48317/

@github-actionsgithub-actionsBot mentioned this pull request Dec 8, 2022
Open
8 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48346/

This was referenced Dec 9, 2022
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48398/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2022
@github-actionsgithub-actionsBot mentioned this pull request Dec 11, 2022
Open
11 tasks
@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8273320 into nodejs:mainDec 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8273320

@github-actionsgithub-actionsBot mentioned this pull request Dec 12, 2022
Open
11 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
@bnoordhuis@targos
src: make structuredClone work for process.env
a172601
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Dec 12, 2022
Merged
@github-actionsgithub-actionsBot mentioned this pull request Dec 13, 2022
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@bnoordhuis@targos
src: make structuredClone work for process.env
b35ebeb
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis@danielleadams
src: make structuredClone work for process.env
b99e77b
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@bnoordhuis@danielleadams
src: make structuredClone work for process.env
b88ee54
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@bnoordhuis@danielleadams
src: make structuredClone work for process.env
f995a06
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

structuredClone does not work on process.env

4 participants

@bnoordhuis@nodejs-github-bot@addaleax@anonrig