Skip to content

test: move test file to sequential/ due to timing issues - #45722

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
sonimadhuri:move_test_to_run_sequentially
May 11, 2024
Merged

test: move test file to sequential/ due to timing issues#45722
aduh95 merged 1 commit into
nodejs:mainfrom
sonimadhuri:move_test_to_run_sequentially

Conversation

@sonimadhuri

@sonimadhurisonimadhuri commented Dec 3, 2022•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Moving test-http-server-request-timeouts-mixed from tests/parallel to tests/sequential

The flaky test is reproducible when we run tools/test.py -j96 --repeat=1024 test/parallel/test-http-server-request-timeouts-mixed.js. I tried tuning the timeouts at which the values are asserted, but they still seem to fail because of timing issues when the system is burdened.

As a workaround, I have moved the test to run sequentially(verified it with tools/test.py -j96 --repeat=128 test/sequential/test-http-server-request-timeouts-mixed.js)

Fixes: #43465

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 3, 2022
@TrottTrott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 3, 2022
@Trott

Trott commented Dec 3, 2022

Copy link
Copy Markdown
Member

Closes: #43465

@Trott

Trott commented Dec 3, 2022

Copy link
Copy Markdown
Member

@nodejs/http @nodejs/testing

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48288/

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53418/

ShogunPanda
ShogunPanda approved these changes Aug 18, 2023
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!

mcollina
mcollina approved these changes Aug 18, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Aug 21, 2023
Open
Open
Open
@aduh95
aduh95force-pushed the move_test_to_run_sequentially branch from 6ae29c5 to 07fcb59CompareMay 11, 2024 11:01
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59096/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@aduh95
aduh95 merged commit b41ab9d into nodejs:mainMay 11, 2024
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Landed in b41ab9d

targos pushed a commit that referenced this pull request May 12, 2024
@sonimadhuri@targos
test: move test-http-server-request-timeouts-mixed to sequential
5d91cf1
PR-URL: #45722Fixes: #43465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targostargos mentioned this pull request May 13, 2024
Merged
@marco-ippolitomarco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@sonimadhuri@marco-ippolito
test: move test-http-server-request-timeouts-mixed to sequential
556e9a2
PR-URL: #45722Fixes: #43465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@sonimadhuri@eliphazbouye
test: move test-http-server-request-timeouts-mixed to sequential
0f01662
PR-URL: nodejs#45722Fixes: nodejs#43465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@ShogunPandaShogunPandaShogunPanda approved these changes
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-http-server-request-timeouts-mixed

7 participants

@sonimadhuri@Trott@nodejs-github-bot@aduh95@mcollina@ShogunPanda@joyeecheung